linux-kernel - Re: [PATCH 1/2] add binding for iio adc driver for TI ADS1018

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <08278938-2a19-efc8-b111-73aa9ab2c28d@nxp.com>
Date:   Mon, 8 Nov 2021 20:45:43 +0200
From:   Daniel Baluta <daniel.baluta@....com>
To:     Iain Hunter <drhunter95@...il.com>
Cc:     iain@...terembedded.co.uk, Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>, linux-iio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] add binding for iio adc driver for TI ADS1018

This looks good to me with the only mention that I don't actually have 
time to maintain this :(.

Perhaps you can add yourself?

On 11/8/21 8:43 PM, Iain Hunter wrote:
> Add a new binding for new IIO ADS1018 driver.
>
> Signed-off-by: Iain Hunter <drhunter95@...il.com>
> ---
>   .../bindings/iio/adc/ti,ads1018.yaml          | 109 ++++++++++++++++++
>   1 file changed, 109 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads1018.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads1018.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads1018.yaml
> new file mode 100644
> index 000000000000..ba0fdfba2c45
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads1018.yaml
> @@ -0,0 +1,109 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/ti,ads1018.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI ADS1018 4 channel SPI analog to digital converter
> +
> +maintainers:
> +  - Daniel Baluta <daniel.baluta@....com>
> +
> +description: |
> +  Datasheet at: https://www.ti.com/lit/gpn/ads1018
> +  Supports both single ended and differential channels.
> +
> +properties:
> +  compatible:
> +    const: ti,ads1018
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 0
> +
> +  "#io-channel-cells":
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - "#address-cells"
> +  - "#size-cells"
> +
> +additionalProperties: false
> +
> +patternProperties:
> +  "^channel@[0-7]+$":
> +    type: object
> +    description:
> +      Child nodes needed for each channel that the platform uses.
> +
> +    properties:
> +      reg:
> +        description: |
> +          0: Voltage over AIN0 and AIN1.
> +          1: Voltage over AIN0 and AIN3.
> +          2: Voltage over AIN1 and AIN3.
> +          3: Voltage over AIN2 and AIN3.
> +          4: Voltage over AIN0 and GND.
> +          5: Voltage over AIN1 and GND.
> +          6: Voltage over AIN2 and GND.
> +          7: Voltage over AIN3 and GND.
> +        items:
> +          - minimum: 0
> +            maximum: 7
> +
> +      ti,gain:
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        minimum: 0
> +        maximum: 5
> +        description: |
> +          pga is the programmable gain amplifier (values are full scale)
> +          0: +/- 6.144 V
> +          1: +/- 4.096 V
> +          2: +/- 2.048 V (default)
> +          3: +/- 1.024 V
> +          4: +/- 0.512 V
> +          5: +/- 0.256 V
> +
> +      ti,datarate:
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        minimum: 0
> +        maximum: 6
> +        description: |
> +          Data acquisition rate in samples per second
> +          0: 128
> +          1: 250
> +          2: 490
> +          3: 920
> +          4: 1600 (default)
> +          5: 2400
> +          6: 3300
> +
> +    required:
> +      - reg
> +
> +examples:
> +  - |
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        adc@1 {
> +            compatible = "ti,ads1018";
> +            reg = <0x1>;
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +            channel@4 {
> +              reg = <4>;
> +              ti,gain = <3>;
> +              ti,datarate = <5>;
> +            };
> +        };
> +    };
> +...