linux-kernel - Re: [PATCH] soc: ti: wkup_m3_ipc: Fix return type error in wkup_m3_rproc_boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 08 Nov 2021 13:18:41 -0600
From:   ebiederm@...ssion.com (Eric W. Biederman)
To:     Nathan Chancellor <nathan@...nel.org>
Cc:     Santosh Shilimkar <ssantosh@...nel.org>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Arnd Bergmann <arnd@...nel.org>
Subject: Re: [PATCH] soc: ti: wkup_m3_ipc: Fix return type error in wkup_m3_rproc_boot_thread()

Nathan Chancellor <nathan@...nel.org> writes:

> This function should not return a value:
>
> drivers/soc/ti/wkup_m3_ipc.c: In function 'wkup_m3_rproc_boot_thread':
> drivers/soc/ti/wkup_m3_ipc.c:429:16: error: 'return' with a value, in function returning void [-Werror=return-type]
>   429 |         return 0;
>       |                ^
> drivers/soc/ti/wkup_m3_ipc.c:416:13: note: declared here
>   416 | static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
>       |             ^~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors

Apologies for not replying to this sooner.  I did not realize at first
that this was in response to one of my changes.

Arnd also reported this and included a correct fix please see:
https://lkml.kernel.org/r/20211105075119.2327190-1-arnd@kernel.org

Thank you,
Eric
>
> Fixes: 111e70490d2a ("exit/kthread: Have kernel threads return instead of calling do_exit")
> Signed-off-by: Nathan Chancellor <nathan@...nel.org>
> ---
>  drivers/soc/ti/wkup_m3_ipc.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
> index 0733443a2631..2238beb40f8d 100644
> --- a/drivers/soc/ti/wkup_m3_ipc.c
> +++ b/drivers/soc/ti/wkup_m3_ipc.c
> @@ -425,8 +425,6 @@ static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
>  		dev_err(dev, "rproc_boot failed\n");
>  	else
>  		m3_ipc_state = m3_ipc;
> -
> -	return 0;
>  }
>  
>  static int wkup_m3_ipc_probe(struct platform_device *pdev)
>
> base-commit: ac4fdfaf4792d41ad7b24d1c8ab486aeb7ccd495