linux-kernel - RE: [PATCH] RDMA/bnxt_re: remove unneeded variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 9 Nov 2021 14:30:51 +0000
From:   Devesh Sharma <devesh.s.sharma@...cle.com>
To:     "cgel.zte@...il.com" <cgel.zte@...il.com>,
        "selvin.xavier@...adcom.com" <selvin.xavier@...adcom.com>
CC:     "dledford@...hat.com" <dledford@...hat.com>,
        "jgg@...pe.ca" <jgg@...pe.ca>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Changcheng Deng <deng.changcheng@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: RE: [PATCH] RDMA/bnxt_re: remove unneeded variable



> -----Original Message-----
> From: cgel.zte@...il.com <cgel.zte@...il.com>
> Sent: 09 November 2021 17:02
> To: selvin.xavier@...adcom.com
> Cc: dledford@...hat.com; jgg@...pe.ca; linux-rdma@...r.kernel.org; linux-
> kernel@...r.kernel.org; Changcheng Deng
> <deng.changcheng@....com.cn>; Zeal Robot <zealci@....com.cn>
> Subject: [PATCH] RDMA/bnxt_re: remove unneeded variable
> 
> From: Changcheng Deng <deng.changcheng@....com.cn>
> 
> Fix the following coccicheck review:
> ./drivers/infiniband/hw/bnxt_re/main.c: 896: 5-7: Unneeded variable
> 
> Remove unneeded variable used to store return value.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@....com.cn>
> ---
>  drivers/infiniband/hw/bnxt_re/main.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/bnxt_re/main.c
> b/drivers/infiniband/hw/bnxt_re/main.c
> index 4fa3b14b2613..2ce0e75f7b2d 100644
> --- a/drivers/infiniband/hw/bnxt_re/main.c
> +++ b/drivers/infiniband/hw/bnxt_re/main.c
> @@ -894,7 +894,6 @@ static int bnxt_re_srqn_handler(struct bnxt_qplib_nq
> *nq,
>  	struct bnxt_re_srq *srq = container_of(handle, struct bnxt_re_srq,
>  					       qplib_srq);
>  	struct ib_event ib_event;
> -	int rc = 0;
> 
>  	ib_event.device = &srq->rdev->ibdev;
>  	ib_event.element.srq = &srq->ib_srq;
> @@ -908,7 +907,7 @@ static int bnxt_re_srqn_handler(struct bnxt_qplib_nq
> *nq,
>  		(*srq->ib_srq.event_handler)(&ib_event,
>  					     srq->ib_srq.srq_context);
>  	}
> -	return rc;
> +	return 0;
>  }
> 
>  static int bnxt_re_cqn_handler(struct bnxt_qplib_nq *nq,

Looks good to me
Reviewed-By: Devesh Sharma <devesh.s.sharma@...cle.com>
> --
> 2.25.1