linux-kernel - Re: [PATCH] MIPS: VDSO: remove -nostdlib compiler flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211109153040.GD12535@alpha.franken.de>
Date:   Tue, 9 Nov 2021 16:30:40 +0100
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     linux-mips@...ux-mips.org, clang-built-linux@...glegroups.com,
        Nathan Chancellor <nathan@...nel.org>,
        linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org,
        zhaoxiao <zhaoxiao@...ontech.com>
Subject: Re: [PATCH] MIPS: VDSO: remove -nostdlib compiler flag

On Mon, Nov 08, 2021 at 01:19:38AM +0900, Masahiro Yamada wrote:
> The -nostdlib option requests the compiler to not use the standard
> system startup files or libraries when linking. It is effective only
> when $(CC) is used as a linker driver.
> 
> Since commit 2ff906994b6c ("MIPS: VDSO: Use $(LD) instead of $(CC) to
> link VDSO"), $(LD) is directly used, hence -nostdlib is unneeded.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
> 
>  arch/mips/vdso/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/vdso/Makefile b/arch/mips/vdso/Makefile
> index 1b2ea34c3d3b..d65f55f67e19 100644
> --- a/arch/mips/vdso/Makefile
> +++ b/arch/mips/vdso/Makefile
> @@ -57,7 +57,7 @@ endif
>  
>  # VDSO linker flags.
>  ldflags-y := -Bsymbolic --no-undefined -soname=linux-vdso.so.1 \
> -	$(filter -E%,$(KBUILD_CFLAGS)) -nostdlib -shared \
> +	$(filter -E%,$(KBUILD_CFLAGS)) -shared \
>  	-G 0 --eh-frame-hdr --hash-style=sysv --build-id=sha1 -T
>  
>  CFLAGS_REMOVE_vdso.o = $(CC_FLAGS_FTRACE)
> -- 
> 2.30.2

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]