linux-kernel - Re: [PATCH] MIPS: Allow modules to set board_be

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211109152905.GA12535@alpha.franken.de>
Date:   Tue, 9 Nov 2021 16:29:05 +0100
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     linux-mips@...r.kernel.org, Guenter Roeck <linux@...ck-us.net>,
        "Maciej W. Rozycki" <macro@...am.me.uk>,
        "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" 
        <bcm-kernel-feedback-list@...adcom.com>,
        Mike Rapoport <rppt@...nel.org>,
        Yanteng Si <siyanteng@...ngson.cn>,
        Serge Semin <fancer.lancer@...il.com>,
        David Hildenbrand <david@...hat.com>,
        Liam Howlett <liam.howlett@...cle.com>,
        Jens Axboe <axboe@...nel.dk>,
        Johannes Thumshirn <johannes.thumshirn@....com>,
        open list <linux-kernel@...r.kernel.org>,
        "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] MIPS: Allow modules to set board_be_handler

On Fri, Nov 05, 2021 at 10:30:47AM -0700, Florian Fainelli wrote:
> After making the brcmstb_gisb driver modular with 707a4cdf86e5 ("bus:
> brcmstb_gisb: Allow building as module") Guenter reported that mips
> allmodconfig failed to link because board_be_handler was referenced.
> 
> Thomas indicated that if we were to continue making the brcmstb_gisb
> driver modular for MIPS we would need to introduce a function that
> allows setting the board_be_handler and export that function towards
> modules.
> 
> This is what is being done here: board_be_handler is made static and is
> now settable with a mips_set_be_handler() function which is exported.
> 
> Reported-by: Guenter Roeck <linux@...ck-us.net>
> Suggested-by: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> Fixes: 707a4cdf86e5 ("bus: brcmstb_gisb: Allow building as module")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
>  arch/mips/dec/setup.c                 | 6 +++---
>  arch/mips/include/asm/traps.h         | 2 +-
>  arch/mips/kernel/traps.c              | 8 +++++++-
>  arch/mips/sgi-ip22/ip22-berr.c        | 2 +-
>  arch/mips/sgi-ip22/ip28-berr.c        | 2 +-
>  arch/mips/sgi-ip27/ip27-berr.c        | 2 +-
>  arch/mips/sgi-ip32/ip32-berr.c        | 2 +-
>  arch/mips/sibyte/swarm/setup.c        | 2 +-
>  arch/mips/txx9/generic/setup_tx4927.c | 2 +-
>  arch/mips/txx9/generic/setup_tx4938.c | 2 +-
>  arch/mips/txx9/generic/setup_tx4939.c | 2 +-
>  drivers/bus/brcmstb_gisb.c            | 2 +-
>  12 files changed, 20 insertions(+), 14 deletions(-)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]