linux-kernel - Re: [PATCH] char: ppdev: fixed a validation issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YYqWuYK/c6D9K3Xi@kroah.com>
Date:   Tue, 9 Nov 2021 16:41:45 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Vihas Mak <makvihas@...il.com>
Cc:     sudipm.mukherjee@...il.com, arnd@...db.de,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] char: ppdev: fixed a validation issue

On Tue, Nov 09, 2021 at 09:04:57PM +0530, Vihas Mak wrote:
> > What happens today if the mode is not set properly?  Will the code paths
> > error out eventually, or will the call succeed?  The problem is that
> > there might be code that is working today that would break with a change
> > like this, as again, this is a very old driver.
> 
> I see. So I guess this driver might be better off without any changes,
> as new changes might break things more severely.

Changes in behavior always have the ability to break things.  What other
changes do you want to make to this old driver that might cause
problems?

And you didn't answer my question above, what happens if the mode is not
set properly today?

thanks,

greg k-h