[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20211109124046.2a772bcb@gandalf.local.home>
Date: Tue, 9 Nov 2021 12:40:46 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Sai Prakash Ranjan <quic_saipraka@...cinc.com>
Cc: Will Deacon <will@...nel.org>,
Catalin Marinas <catalin.marinas@....com>,
<quic_psodagud@...cinc.com>, Marc Zyngier <maz@...nel.org>,
<gregkh@...uxfoundation.org>, <arnd@...db.de>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
<mingo@...hat.com>, <jbaron@...mai.com>, <jim.cromie@...il.com>
Subject: Re: [PATCHv3 3/3] dynamic_debug: Add a flag for dynamic event
tracing
On Tue, 9 Nov 2021 23:00:11 +0530
Sai Prakash Ranjan <quic_saipraka@...cinc.com> wrote:
> Ah that's a very good idea, descriptor does contain the module, file name.
> We can probably even pass the module name,file name as string from the
> descriptor itself to event?
> Perhaps we can do that for all trace events and not just this trace
> event? Just like the trace event name displayed
> with trace events, perhaps have file name,module name displayed when
> dynamic debug is enabled? Filtering by
> filename is pretty useful since most of these usecases in debugging will
> be with respect to some driver or subsystems.
If we add this for all events, it would require a lot of changes to all
users of tracepoints, as it would require adding a new parameter to the
callbacks.
We could add a flag in the registering that states that the callback is OK
for it, and it passes that data as well.
Let me look into this for a bit. I may not have something this week, but
we should look into this more before adding little hacks that do this one
at a time like this patch.
-- Steve
Powered by blists - more mailing lists