linux-kernel - Re: [PATCH 1/2] of: Support using 'mask' in making device bus id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZOuhA8w4CYetBKfaZ_wKT4QgKe=bffdYDTB68ihVE3-A@mail.gmail.com>
Date:   Tue, 9 Nov 2021 23:20:17 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Stephen Boyd <sboyd@...nel.org>,
        Sudeep Holla <Sudeep.Holla@....com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Guenter Roeck <linux@...ck-us.net>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, Frank Rowand <frowand.list@...il.com>
Subject: Re: [PATCH 1/2] of: Support using 'mask' in making device bus id

On Tue, Nov 9, 2021 at 5:46 PM Rob Herring <robh@...nel.org> wrote:

> Commit 25b892b583cc ("ARM: dts: arm: Update register-bit-led nodes
> 'reg' and node names") added a 'reg' property to nodes. This change has
> the side effect of changing how the kernel generates the device name.
> The assumption was a translatable 'reg' address is unique. However, in
> the case of the register-bit-led binding (and a few others) that is not
> the case. The 'mask' property must also be used in this case to make a
> unique device name.
>
> Fixes: 25b892b583cc ("ARM: dts: arm: Update register-bit-led nodes 'reg' and node names")
> Reported-by: Guenter Roeck <linux@...ck-us.net>
> Cc: stable@...r.kernel.org
> Cc: Frank Rowand <frowand.list@...il.com>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Signed-off-by: Rob Herring <robh@...nel.org>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij