linux-kernel - Re: [PATCH v7 2/2] pinctrl: amd: Fix wakeups when IRQ is shared with SCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdahdqrkwEZYVuJLogqW+MobNSbSGsy4HjfBdoUfg0_bUQ@mail.gmail.com>
Date:   Tue, 9 Nov 2021 01:38:35 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Mario Limonciello <mario.limonciello@....com>
Cc:     Basavaraj Natikar <Basavaraj.Natikar@....com>,
        Shyam Sundar S K <Shyam-sundar.S-k@....com>,
        "open list:PIN CONTROL SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        linux-acpi@...r.kernel.org,
        Nehal Shah <Nehal-bakulchandra.Shah@....com>,
        Joerie de Gram <j.de.gram@...il.com>
Subject: Re: [PATCH v7 2/2] pinctrl: amd: Fix wakeups when IRQ is shared with SCI

On Mon, Nov 1, 2021 at 2:49 AM Mario Limonciello
<mario.limonciello@....com> wrote:

> On some Lenovo AMD Gen2 platforms the IRQ for the SCI and pinctrl drivers
> are shared.  Due to how the s2idle loop handling works, this case needs
> an extra explicit check whether the interrupt was caused by SCI or by
> the GPIO controller.
>
> To fix this rework the existing IRQ handler function to function as a
> checker and an IRQ handler depending on the calling arguments.
>
> BugLink: https://gitlab.freedesktop.org/drm/amd/-/issues/1738
> Reported-by: Joerie de Gram <j.de.gram@...il.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> Acked-by: Basavaraj Natikar <Basavaraj.Natikar@....com>

This v7 patch applied for fixes.

Sorry for the delay, I was busy with the merge window.
Once the merge window concludes I will rebase this on
-rc1 and send upstream.

Yours,
Linus Walleij