linux-kernel - Re: [PATCH 1/6] input: touchscreen: zinitix: Make sure the IRQ is allocated before it gets enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 9 Nov 2021 05:37:33 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Nikita Travkin <nikita@...n.ru>
Cc:     dmitry.torokhov@...il.com, robh+dt@...nel.org,
        Michael.Srba@...nam.cz, broonie@...nel.org,
        linux-input@...r.kernel.org, devicetree@...r.kernel.org,
        phone-devel@...r.kernel.org, linux-kernel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH 1/6] input: touchscreen: zinitix: Make sure the IRQ is
 allocated before it gets enabled

On Wed, Oct 27, 2021 at 8:15 PM Nikita Travkin <nikita@...n.ru> wrote:

> Since irq request is the last thing in the driver probe, it happens
> later than the input device registration. This means that there is a
> small time window where if the open method is called the driver will
> attempt to enable not yet available irq.
>
> Fix that by moving the irq request before the input device registration.
>
> Fixes: 26822652c85e ("Input: add zinitix touchscreen driver")
> Signed-off-by: Nikita Travkin <nikita@...n.ru>

Good catch!
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij