linux-kernel - Re: [PATCH] thermal/drivers/int340x: limit Kconfig to 64-bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a22a1eeb-c7a0-74c1-46e2-0a7bada73520@infradead.org>
Date:   Mon, 8 Nov 2021 21:54:10 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Arnd Bergmann <arnd@...nel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
Cc:     Arnd Bergmann <arnd@...db.de>, Amit Kucheria <amitk@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thermal/drivers/int340x: limit Kconfig to 64-bit

On 11/8/21 3:13 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> 32-bit processors cannot generally access 64-bit MMIO registers
> atomically, and it is unknown in which order the two halves of
> this registers would need to be read:
> 
> drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c: In function 'send_mbox_cmd':
> drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c:79:37: error: implicit declaration of function 'readq'; did you mean 'readl'? [-Werror=implicit-function-declaration]
>     79 |                         *cmd_resp = readq((void __iomem *) (proc_priv->mmio_base + MBOX_OFFSET_DATA));
>        |                                     ^~~~~
>        |                                     readl
> 
> The driver already does not build for anything other than x86,
> so limit it further to x86-64.
> 
> Fixes: aeb58c860dc5 ("thermal/drivers/int340x: processor_thermal: Suppot 64 bit RFIM responses")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   drivers/thermal/intel/int340x_thermal/Kconfig | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig b/drivers/thermal/intel/int340x_thermal/Kconfig
> index 45c31f3d6054..5d046de96a5d 100644
> --- a/drivers/thermal/intel/int340x_thermal/Kconfig
> +++ b/drivers/thermal/intel/int340x_thermal/Kconfig
> @@ -5,12 +5,12 @@
>   
>   config INT340X_THERMAL
>   	tristate "ACPI INT340X thermal drivers"
> -	depends on X86 && ACPI && PCI
> +	depends on X86_64 && ACPI && PCI
>   	select THERMAL_GOV_USER_SPACE
>   	select ACPI_THERMAL_REL
>   	select ACPI_FAN
>   	select INTEL_SOC_DTS_IOSF_CORE
> -	select PROC_THERMAL_MMIO_RAPL if X86_64 && POWERCAP
> +	select PROC_THERMAL_MMIO_RAPL if POWERCAP
>   	help
>   	  Newer laptops and tablets that use ACPI may have thermal sensors and
>   	  other devices with thermal control capabilities outside the core
> 

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

-- 
~Randy