linux-kernel - Re: [PATCH 1/3] x86/amd_nb: Add AMD Family 19h Models (10h-1Fh) and (A0h-AFh) PCI IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YYm8h1wDTAm7Rkf5@rocinante>
Date:   Tue, 9 Nov 2021 01:10:47 +0100
From:   Krzysztof Wilczyński <kw@...ux.com>
To:     Babu Moger <babu.moger@....com>
Cc:     tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
        dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
        clemens@...isch.de, jdelvare@...e.com, linux@...ck-us.net,
        bhelgaas@...gle.com, linux-kernel@...r.kernel.org,
        linux-hwmon@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH 1/3] x86/amd_nb: Add AMD Family 19h Models (10h-1Fh) and
 (A0h-AFh) PCI IDs

Hello!

> Add the new PCI Device IDs to support new generation of AMD 19h family of
> processors.

This commit message matches the spirit of past additions very well, as per:

  commit b3f79ae45904 ("x86/amd_nb: Add Family 19h PCI IDs")

Admittedly, it would be nice to know what platform and/or generations of
AMD family of CPUs this is for.  Unless this is somewhat confidential and
in which case it would be fair enough.

For the following PCI related changes:

[...]
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -555,6 +555,7 @@
>  #define PCI_DEVICE_ID_AMD_17H_M60H_DF_F3 0x144b
>  #define PCI_DEVICE_ID_AMD_17H_M70H_DF_F3 0x1443
>  #define PCI_DEVICE_ID_AMD_19H_DF_F3	0x1653
> +#define PCI_DEVICE_ID_AMD_19H_M10H_DF_F3 0x14b0
>  #define PCI_DEVICE_ID_AMD_19H_M40H_DF_F3 0x167c
>  #define PCI_DEVICE_ID_AMD_19H_M50H_DF_F3 0x166d
>  #define PCI_DEVICE_ID_AMD_CNB17H_F3	0x1703

Acked-by: Krzysztof Wilczyński <kw@...ux.com>

	Krzysztof