linux-kernel - Re: [PATCH 1/2] arm/arm64: dts: Enable 2.5G Ethernet port on CN9130-CRB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e2c41180-591f-5a61-e4a9-f526fcbe0abf@alliedtelesis.co.nz>
Date:   Tue, 9 Nov 2021 01:00:12 +0000
From:   Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To:     Gregory CLEMENT <gregory.clement@...tlin.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "sebastian.hesselbarth@...il.com" <sebastian.hesselbarth@...il.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "kostap@...vell.com" <kostap@...vell.com>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] arm/arm64: dts: Enable 2.5G Ethernet port on
 CN9130-CRB

Hi Gregory,

On 14/10/21 3:52 am, Gregory CLEMENT wrote:
> Hello Chris,
>
>> Enable the 2.5G Ethernet port by setting the status to "okay" and the
>> phy-mode to "2500base-x" on the cn9130-crb boards. Tested on a
>> CN9130-CRB-A.
>>
>> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> As I am not sure that next week the pull request will be accepted when
> you will send the v2 for the second patch, I already applied the one on
> mvebu/dt64

I pulled 
git://git.kernel.org/pub/scm/linux/kernel/git/gclement/mvebu.git today 
and can't see this patch. Am I looking in the right place?

> Thanks,
>
> Gregory
>
>
>> ---
>>
>> The Marvell SDK adds 2500base-t and uses it in the equivalent dtsi but
>> looking at the documentation for both the SoC and the PHY I think
>> 2500base-x is correct for the system interface (the line side is
>> 2500base-t).
>>
>>   arch/arm64/boot/dts/marvell/cn9130-crb.dtsi | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/marvell/cn9130-crb.dtsi b/arch/arm64/boot/dts/marvell/cn9130-crb.dtsi
>> index 505ae69289f6..e7918f325646 100644
>> --- a/arch/arm64/boot/dts/marvell/cn9130-crb.dtsi
>> +++ b/arch/arm64/boot/dts/marvell/cn9130-crb.dtsi
>> @@ -214,8 +214,8 @@ &cp0_eth1 {
>>   };
>>   
>>   &cp0_eth2 {
>> -	/* This port uses "2500base-t" phy-mode */
>> -	status = "disabled";
>> +	status = "okay";
>> +	phy-mode = "2500base-x";
>>   	phy = <&nbaset_phy0>;
>>   	phys = <&cp0_comphy5 2>;
>>   };
>> -- 
>> 2.33.0
>>