linux-kernel - Re: [PATCH] iio/adc: ingenic: fix (MIPS) ingenic-adc build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <390B2R.ICFJKTTX7S392@crapouillou.net>
Date:   Tue, 09 Nov 2021 12:05:27 +0000
From:   Paul Cercueil <paul@...pouillou.net>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>,
        Artur Rojek <contact@...ur-rojek.eu>,
        linux-mips@...r.kernel.org, Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        linux-iio@...r.kernel.org, Florian Fainelli <f.fainelli@...il.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Subject: Re: [PATCH] iio/adc: ingenic: fix (MIPS) ingenic-adc build errors

Hi Randy,

Le sam., nov. 6 2021 at 10:49:32 -0700, Randy Dunlap 
<rdunlap@...radead.org> a écrit :
> MIPS does not always provide clk*() interfaces and there are no
> always-present stubs for them, so depending on "MIPS || COMPILE_TEST"
> is not strong enough to prevent build errors.
> 
> Likewise MACH_INGENIC_SOC || COMPILE_TEST is not strong enough
> since if only COMPILE_TEST=y (with some other MIPS MACH_ or CPU or
> BOARD setting), there are still the same build errors.
> 
> It looks like depending on MACH_INGENIC_SOC is the only thing that is
> sufficient here in order to prevent build errors.

Should be "depends on MACH_INGENIC". This symbol is selected when 
building a kernel tailored for Ingenic boards (CONFIG_MACH_INGENIC_SOC) 
and also selected when building a generic MIPS kernel that supports 
Ingenic SoCs (CONFIG_BOARD_INGENIC).

Cheers,
-Paul

> 
> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function 
> `jz4770_adc_init_clk_div':
> ingenic-adc.c:(.text+0xe4): undefined reference to `clk_get_parent'
> mips-linux-ld: drivers/iio/adc/ingenic-adc.o: in function 
> `jz4725b_adc_init_clk_div':
> ingenic-adc.c:(.text+0x1b8): undefined reference to `clk_get_parent'
> 
> Fixes: 1a78daea107d ("IIO: add Ingenic JZ47xx ADC driver.")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Cc: Artur Rojek <contact@...ur-rojek.eu>
> Cc: Paul Cercueil <paul@...pouillou.net>
> Cc: linux-mips@...r.kernel.org
> Cc: Jonathan Cameron <jic23@...nel.org>
> Cc: Lars-Peter Clausen <lars@...afoo.de>
> Cc: linux-iio@...r.kernel.org
> Cc: Florian Fainelli <f.fainelli@...il.com>
> Cc: Andy Shevchenko <andy.shevchenko@...il.com>
> ---
>  drivers/iio/adc/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20211105.orig/drivers/iio/adc/Kconfig
> +++ linux-next-20211105/drivers/iio/adc/Kconfig
> @@ -501,7 +501,7 @@ config INA2XX_ADC
> 
>  config INGENIC_ADC
>  	tristate "Ingenic JZ47xx SoCs ADC driver"
> -	depends on MIPS || COMPILE_TEST
> +	depends on MACH_INGENIC_SOC
>  	select IIO_BUFFER
>  	help
>  	  Say yes here to build support for the Ingenic JZ47xx SoCs ADC 
> unit.