linux-kernel - Re: [PATCH] mtd: rawnand: denali: Add the dependency on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 9 Nov 2021 14:28:28 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Cai Huoqing <caihuoqing@...du.com>
Cc:     Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtd: rawnand: denali: Add the dependency on HAS_IOMEM

Hi Cai,

caihuoqing@...du.com wrote on Tue, 9 Nov 2021 20:54:55 +0800:

> The helper function devm_platform_ioremap_resource_xxx()
> needs HAS_IOMEM enabled, so add the dependency on HAS_IOMEM.
> 
> Signed-off-by: Cai Huoqing <caihuoqing@...du.com>
> ---

 Can you please add a Fixes tag?

>  drivers/mtd/nand/raw/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
> index 67b7cb67c030..0a45d3c6c15b 100644
> --- a/drivers/mtd/nand/raw/Kconfig
> +++ b/drivers/mtd/nand/raw/Kconfig
> @@ -26,7 +26,7 @@ config MTD_NAND_DENALI_PCI
>  config MTD_NAND_DENALI_DT
>  	tristate "Denali NAND controller as a DT device"
>  	select MTD_NAND_DENALI
> -	depends on HAS_DMA && HAVE_CLK && OF
> +	depends on HAS_DMA && HAVE_CLK && OF && HAS_IOMEM
>  	help
>  	  Enable the driver for NAND flash on platforms using a Denali NAND
>  	  controller as a DT device.


Thanks,
Miquèl