linux-kernel - Re: [PATCH v2 1/2] mmc: Add SD/SDIO driver for Sunplus SP7021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <92e8310d-0688-0df3-2422-4b179fd9cbbd@infradead.org>
Date:   Tue, 9 Nov 2021 21:44:27 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Lh Kuo 郭力豪 <lh.Kuo@...plus.com>,
        "LH.Kuo" <lhjeff911@...il.com>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "daniel.thompson@...aro.org" <daniel.thompson@...aro.org>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>,
        "u.kleine-koenig@...gutronix.de" <u.kleine-koenig@...gutronix.de>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Cc:     "qinjian@...lus1.com" <qinjian@...lus1.com>,
        Wells Lu 呂芳騰 <wells.lu@...plus.com>
Subject: Re: [PATCH v2 1/2] mmc: Add SD/SDIO driver for Sunplus SP7021

Hi--

On 11/9/21 9:40 PM, Lh Kuo 郭力豪 wrote:
> Hi
> 
>> -----Original Message-----
>> From: Randy Dunlap <rdunlap@...radead.org>
>> Sent: Wednesday, November 10, 2021 10:33 AM
>> To: LH.Kuo <lhjeff911@...il.com>; p.zabel@...gutronix.de;
>> daniel.thompson@...aro.org; lee.jones@...aro.org;
>> u.kleine-koenig@...gutronix.de; ulf.hansson@...aro.org; robh+dt@...nel.org;
>> linux-kernel@...r.kernel.org; linux-mmc@...r.kernel.org;
>> devicetree@...r.kernel.org
>> Cc: qinjian@...lus1.com; Wells Lu 呂芳騰 <wells.lu@...plus.com>; Lh Kuo
>> 郭力豪 <lh.Kuo@...plus.com>
>> Subject: Re: [PATCH v2 1/2] mmc: Add SD/SDIO driver for Sunplus SP7021
>>
>> Hi--
>>
>> On 11/8/21 11:58 PM, LH.Kuo wrote:
>>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
>>> index 5af8494..2aba9eb 100644
>>> --- a/drivers/mmc/host/Kconfig
>>> +++ b/drivers/mmc/host/Kconfig
>>> @@ -1091,5 +1091,15 @@ config MMC_OWL
>>>    	  This selects support for the SD/MMC Host Controller on
>>>    	  Actions Semi Owl SoCs.
>>>
>>> +config MMC_SP_SDV2
>>> +	tristate "Sunplus SP7021 SD/SDIO Controller"
>>> +	depends on SOC_SP7021
>>> +	help
>>> +		If you say yes here, you will get support for SD/SDIO host interface
>>> +		on sunplus Socs.
>>
>> 		   Sunplus SoCs.
>>
>>> +		If you have a controller with this interface, say Y or M here.
>>> +		If unsure, say N.
>>
>> All 4 lines of help text should be indented only with one tab + 2 spaces,
>> not 2 tabs, per coding-style.rst.
>>
>>
>>> +                Sunplus  SD/SDIO Host Controller support"
>>
>> I am thinking that this last line should not be here at all... ???
>>
>>
>> thanks.
>> --
>> ~Randy
> 
> 
> I will make change as below  is it OK ?
> 
> config MMC_SP_SDV2
> 	tristate "Sunplus SP7021 SD/SDIO Controller"
> 	depends on SOC_SP7021
> 	help
> 	  This selects the Sunplus Host Controller Interface
> 	  support present in Sunplus SP7021 SOCs. The controller supports
> 	  SD/SDIO devices.
> 		
> 		If you have a controller with this interface, say Y or M here.
> 		
> 		If unsure, say N.

Too much indentation on the last 2 (non-blank) help text lines.
Should just be one tab + 2 spaces, not 2 tabs.


-- 
~Randy