linux-kernel - Re: [PATCH] btrfs: make 1-bit bit-fields unsigned int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YYws2G9kgER/zeeg@localhost.localdomain>
Date:   Wed, 10 Nov 2021 15:34:32 -0500
From:   Josef Bacik <josef@...icpanda.com>
To:     Colin Ian King <colin.i.king@...glemail.com>
Cc:     Chris Mason <clm@...com>, David Sterba <dsterba@...e.com>,
        Qu Wenruo <wqu@...e.com>, linux-btrfs@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs: make 1-bit bit-fields unsigned int

On Wed, Nov 10, 2021 at 07:20:08PM +0000, Colin Ian King wrote:
> The bitfields have_csum and io_error are currently signed which is
> not recommended as the representation is an implementation defined
> behaviour. Fix this by making the bit-fields unsigned ints.
> 
> Fixes: 2c36395430b0 ("btrfs: scrub: remove the anonymous structure from scrub_page")
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Reviewed-by: Josef Bacik <josef@...icpanda.com>

Thanks,

Josef