linux-kernel - Re: [PATCH] nvme: fix write zeroes pi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db739cda-2dd7-015a-5ad9-d2d6e44131c6@nvidia.com>
Date:   Wed, 10 Nov 2021 06:10:18 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Klaus Jensen <its@...elevant.dk>
CC:     Keith Busch <kbusch@...nel.org>, Christoph Hellwig <hch@....de>,
        Jens Axboe <axboe@...com>, Sagi Grimberg <sagi@...mberg.me>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        Klaus Jensen <k.jensen@...sung.com>
Subject: Re: [PATCH] nvme: fix write zeroes pi

Klaus,

On 11/4/2021 11:16 AM, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@...sung.com>
> 
> Write Zeroes sets PRACT when block integrity is enabled (as it should),
> but neglects to also set the reftag which is expected by reads. This
> causes protection errors on reads.
> 
> Fix this by setting the reftag for type 1 and 2 (for type 3, reads will
> not check the reftag).
> 
> Signed-off-by: Klaus Jensen <k.jensen@...sung.com>

Patch looks good to me but did you get a chance to test on
multiple non-QEMU controllers ?