linux-kernel - RE: [PATCH] iio: adc: rzg2l_adc: Remove unnecessary print function dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OSZPR01MB7019A331812449B03157D0C8AA939@OSZPR01MB7019.jpnprd01.prod.outlook.com>
Date:   Wed, 10 Nov 2021 22:50:03 +0000
From:   Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>
To:     Xu Wang <vulab@...as.ac.cn>, "jic23@...nel.org" <jic23@...nel.org>,
        "lars@...afoo.de" <lars@...afoo.de>
CC:     "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] iio: adc: rzg2l_adc: Remove unnecessary print function
 dev_err()

Hi Xu,

Thank you for the patch.

> -----Original Message-----
> From: Xu Wang <vulab@...as.ac.cn>
> Sent: 05 November 2021 01:55
> To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>; jic23@...nel.org; lars@...afoo.de
> Cc: linux-iio@...r.kernel.org; linux-renesas-soc@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] iio: adc: rzg2l_adc: Remove unnecessary print function dev_err()
> 
> The print function dev_err() is redundant because
> platform_get_irq() already prints an error.
> 
> Signed-off-by: Xu Wang <vulab@...as.ac.cn>
> ---
>  drivers/iio/adc/rzg2l_adc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>

Cheers,
Prabhakar

> diff --git a/drivers/iio/adc/rzg2l_adc.c b/drivers/iio/adc/rzg2l_adc.c index
> 32fbf57c362f..9d5be52bd948 100644
> --- a/drivers/iio/adc/rzg2l_adc.c
> +++ b/drivers/iio/adc/rzg2l_adc.c
> @@ -506,10 +506,8 @@ static int rzg2l_adc_probe(struct platform_device *pdev)
>  	}
> 
>  	irq = platform_get_irq(pdev, 0);
> -	if (irq < 0) {
> -		dev_err(dev, "no irq resource\n");
> +	if (irq < 0)
>  		return irq;
> -	}
> 
>  	ret = devm_request_irq(dev, irq, rzg2l_adc_isr,
>  			       0, dev_name(dev), adc);
> --
> 2.25.1