linux-kernel - Re: [PATCH] MIPS: generic/yamon-dt: fix uninitialized variable error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 10 Nov 2021 23:26:49 +0000
From:   "Colin King (gmail)" <colin.i.king@...glemail.com>
To:     Colin Ian King <colin.i.king@...glemail.com>,
        Paul Burton <paulburton@...nel.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Ralf Baechle <ralf@...ux-mips.org>,
        James Hogan <jhogan@...nel.org>, linux-mips@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: generic/yamon-dt: fix uninitialized variable error

On 10/11/2021 23:25, Colin Ian King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> In the case where fw_getenv returns an error when fetching values
> for ememsizea and memsize then variable phys_memsize is not assigned
> a variable and will be uninitialized on a zero check of phys_memsize.
> Fix this by initializing phys_memsize to zero.
> 
> Cleans up cppcheck error:
> arch/mips/generic/yamon-dt.c:100:7: error: Uninitialized variable: phys_memsize [uninitvar]
> 
> Fixes: f41d2430bbd6 ("MIPS: generic/yamon-dt: Support > 256MB of RAM")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>   arch/mips/generic/yamon-dt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/generic/yamon-dt.c b/arch/mips/generic/yamon-dt.c
> index a3aa22c77cad..a07a5edbcda7 100644
> --- a/arch/mips/generic/yamon-dt.c
> +++ b/arch/mips/generic/yamon-dt.c
> @@ -75,7 +75,7 @@ static unsigned int __init gen_fdt_mem_array(
>   __init int yamon_dt_append_memory(void *fdt,
>   				  const struct yamon_mem_region *regions)
>   {
> -	unsigned long phys_memsize, memsize;
> +	unsigned long phys_memsize = 0, memsize;
>   	__be32 mem_array[2 * MAX_MEM_ARRAY_ENTRIES];
>   	unsigned int mem_entries;
>   	int i, err, mem_off;
> 

Oops, old SoB. I'll resend a V2.