linux-kernel - Re: [PATCH] speakup: remove redundant assignment of variable i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 11 Nov 2021 00:30:47 +0100
From:   Samuel Thibault <samuel.thibault@...-lyon.org>
To:     Colin Ian King <colin.i.king@...glemail.com>
Cc:     William Hubbs <w.d.hubbs@...il.com>,
        Chris Brannon <chris@...-brannons.com>,
        Kirk Reiser <kirk@...sers.ca>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        speakup@...ux-speakup.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] speakup: remove redundant assignment of variable i

Colin Ian King, le mer. 10 nov. 2021 22:53:01 +0000, a ecrit:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The variable i is being initialized a value that is never read, it is
> re-assigned later on in a for-loop.  The assignment is redundant and
> can be removed.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Samuel Thibault <samuel.thibault@...-lyon.org>

> ---
>  drivers/accessibility/speakup/speakup_acntpc.c | 2 +-
>  drivers/accessibility/speakup/speakup_dtlk.c   | 2 +-
>  drivers/accessibility/speakup/speakup_keypc.c  | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/accessibility/speakup/speakup_acntpc.c b/drivers/accessibility/speakup/speakup_acntpc.c
> index c1ec087dca13..023172ca22ef 100644
> --- a/drivers/accessibility/speakup/speakup_acntpc.c
> +++ b/drivers/accessibility/speakup/speakup_acntpc.c
> @@ -247,7 +247,7 @@ static void synth_flush(struct spk_synth *synth)
>  static int synth_probe(struct spk_synth *synth)
>  {
>  	unsigned int port_val = 0;
> -	int i = 0;
> +	int i;
>  
>  	pr_info("Probing for %s.\n", synth->long_name);
>  	if (port_forced) {
> diff --git a/drivers/accessibility/speakup/speakup_dtlk.c b/drivers/accessibility/speakup/speakup_dtlk.c
> index 92838d3ae9eb..a9dd5c45d237 100644
> --- a/drivers/accessibility/speakup/speakup_dtlk.c
> +++ b/drivers/accessibility/speakup/speakup_dtlk.c
> @@ -316,7 +316,7 @@ static struct synth_settings *synth_interrogate(struct spk_synth *synth)
>  static int synth_probe(struct spk_synth *synth)
>  {
>  	unsigned int port_val = 0;
> -	int i = 0;
> +	int i;
>  	struct synth_settings *sp;
>  
>  	pr_info("Probing for DoubleTalk.\n");
> diff --git a/drivers/accessibility/speakup/speakup_keypc.c b/drivers/accessibility/speakup/speakup_keypc.c
> index 311f4aa0be22..1618be87bff1 100644
> --- a/drivers/accessibility/speakup/speakup_keypc.c
> +++ b/drivers/accessibility/speakup/speakup_keypc.c
> @@ -254,7 +254,7 @@ static void synth_flush(struct spk_synth *synth)
>  static int synth_probe(struct spk_synth *synth)
>  {
>  	unsigned int port_val = 0;
> -	int i = 0;
> +	int i;
>  
>  	pr_info("Probing for %s.\n", synth->long_name);
>  	if (port_forced) {
> -- 
> 2.32.0
>