linux-kernel - checkpatch warns a symbolic link has not a newline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <5DB475451BAA174CB158B5E897FC1525D8B30486@MBS07.vivotek.tw>
Date:   Wed, 10 Nov 2021 06:39:09 +0000
From:   <Michael.Wu@...ics.com>
To:     <apw@...onical.com>, <joe@...ches.com>
CC:     <dwaipayanray1@...il.com>, <lukas.bulwahn@...il.com>,
        <linux-kernel@...r.kernel.org>
Subject: checkpatch warns a symbolic link has not a newline

Hi Andy & Joe,

I have a commit that contains a newly created symbolic link pointing to a certain file. I used ./scripts/checkpatch.pl to check this commit and then I got a WARNING: adding a line without newline at end of file. The symbolic link was created by ln -s.

I'm confused why it returned such a warning. Is the content of the patch not allowed to contain symbolic links? If it is allowed, I think checkpatch.pl can make some improvements, so that symbolic links will not be treated a warnings because of missing newline at end of file.

Best Regards,
Michael Wu