linux-kernel - Re: [PATCH] sched: Split preemption model selection between DYNAMIC & !DYNAMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211110011738.GD288354@lothringen>
Date:   Wed, 10 Nov 2021 02:17:38 +0100
From:   Frederic Weisbecker <frederic@...nel.org>
To:     Valentin Schneider <valentin.schneider@....com>
Cc:     linux-kernel@...r.kernel.org, Mike Galbraith <efault@....de>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH] sched: Split preemption model selection between DYNAMIC
 & !DYNAMIC

On Tue, Nov 09, 2021 at 03:10:57PM +0000, Valentin Schneider wrote:
> +choice
> +	prompt "Default boot-time Preemption Model"
> +	depends on PREEMPT_DYNAMIC
> +	default PREEMPT_NONE_BEHAVIOUR
> +	help
> +	  This option defines the default preemption model of the kernel
> +	  if it hasn't been specified by the "preempt=" command line parameter.
>  
> -config PREEMPT_VOLUNTARY
> -	bool
> +config PREEMPT_NONE_BEHAVIOUR
> +	bool "No Forced Preemption (Server)"
>  
> -config PREEMPT
> -	bool
> -	select PREEMPTION
> -	select UNINLINE_SPIN_UNLOCK if !ARCH_INLINE_SPIN_UNLOCK
> +config PREEMPT_VOLUNTARY_BEHAVIOUR
> +	bool "Voluntary Kernel Preemption (Desktop)"
> +
> +config PREEMPT_BEHAVIOUR
> +	bool "Preemptible Kernel (Low-Latency Desktop)"
> +endchoice

The problem here is that you're duplicating the existing titles
for the static entries and you're losing all the help that text that used to come
along. The point of the BEHAVIOUR thing, further mapping to either
static or dynamic preemption, was to avoid that duplication and keep the
same titles and help for the three behaviour, whether static or dynamic.

Thanks.