linux-kernel - Re: [PATCH 2/5] drm: Move nomodeset kernel parameter handler to the DRM subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211110110442.1743b0d2@eldfell>
Date:   Wed, 10 Nov 2021 11:04:42 +0200
From:   Pekka Paalanen <ppaalanen@...il.com>
To:     Neal Gompa <ngompa13@...il.com>
Cc:     Thomas Zimmermann <tzimmermann@...e.de>,
        Javier Martinez Canillas <javierm@...hat.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Peter Robinson <pbrobinson@...il.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Michel Dänzer <michel@...nzer.net>
Subject: Re: [PATCH 2/5] drm: Move nomodeset kernel parameter handler to the
 DRM subsystem

On Wed, 3 Nov 2021 08:34:20 -0400
Neal Gompa <ngompa13@...il.com> wrote:

> On Wed, Nov 3, 2021 at 8:32 AM Thomas Zimmermann <tzimmermann@...e.de> wrote:
> >
> > Hi
> >
> > Am 03.11.21 um 12:05 schrieb Neal Gompa:  
> > > On Wed, Nov 3, 2021 at 6:48 AM Javier Martinez Canillas
> > > <javierm@...hat.com> wrote:  
> > >>
> > >> The "nomodeset" kernel cmdline parameter is handled by the vgacon driver
> > >> but the exported vgacon_text_force() symbol is only used by DRM drivers.
> > >>
> > >> It makes much more sense for the parameter logic to be in the subsystem
> > >> of the drivers that are making use of it. Let's move that to DRM.
> > >>
> > >> Suggested-by: Daniel Vetter <daniel.vetter@...ll.ch>
> > >> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>
> > >> ---  
> > >
> > > Please no, I'd much rather have a better, more meaningful option
> > > instead of "nomodeset". If anything, I would like this option to
> > > eventually do nothing and replace it with a better named option that's
> > > namespaced by drm on the command-line. That was part of the feedback I
> > > gave in the original patch set, and I still stand by that.  
> >
> > This was nack'ed for now during irc chats with others. There was no
> > clear semantics for the new parameter and nomodeset is good enough for
> > now. I agree that nomodeset is badly named, though.
> >  
> 
> Where are these chats happening? I'm mostly talking to Javier in the
> #devel:fedoraproject.org Matrix room, so I don't know about anything
> else...

OFTC IRC channel #dri-devel


Thanks,
pq

Content of type "application/pgp-signature" skipped