linux-kernel - Re: [PATCH v2 1/2] mmc: Add SD/SDIO driver for Sunplus SP7021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c5c6e83-8176-8b4a-9c2c-f01a262de5de@infradead.org>
Date:   Tue, 9 Nov 2021 18:33:05 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     "LH.Kuo" <lhjeff911@...il.com>, p.zabel@...gutronix.de,
        daniel.thompson@...aro.org, lee.jones@...aro.org,
        u.kleine-koenig@...gutronix.de, ulf.hansson@...aro.org,
        robh+dt@...nel.org, linux-kernel@...r.kernel.org,
        linux-mmc@...r.kernel.org, devicetree@...r.kernel.org
Cc:     qinjian@...lus1.com, wells.lu@...plus.com,
        "LH.Kuo" <lh.kuo@...plus.com>
Subject: Re: [PATCH v2 1/2] mmc: Add SD/SDIO driver for Sunplus SP7021

Hi--

On 11/8/21 11:58 PM, LH.Kuo wrote:
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 5af8494..2aba9eb 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -1091,5 +1091,15 @@ config MMC_OWL
>   	  This selects support for the SD/MMC Host Controller on
>   	  Actions Semi Owl SoCs.
>   
> +config MMC_SP_SDV2
> +	tristate "Sunplus SP7021 SD/SDIO Controller"
> +	depends on SOC_SP7021
> +	help
> +		If you say yes here, you will get support for SD/SDIO host interface
> +		on sunplus Socs.

		   Sunplus SoCs.

> +		If you have a controller with this interface, say Y or M here.
> +		If unsure, say N.

All 4 lines of help text should be indented only with one tab + 2 spaces,
not 2 tabs, per coding-style.rst.


> +                Sunplus  SD/SDIO Host Controller support"

I am thinking that this last line should not be here at all... ???


thanks.
-- 
~Randy