linux-kernel - Re: [Linux-stm32] [PATCH net] net: stmmac: allow a tc-taprio base-time of zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211110123843.3u4jo3xe7plows6r@skbuf>
Date:   Wed, 10 Nov 2021 12:38:43 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Ahmad Fatoum <a.fatoum@...gutronix.de>,
        Michael Olbrich <m.olbrich@...gutronix.de>,
        Holger Assmann <h.assmann@...gutronix.de>
CC:     Kurt Kanzenbach <kurt.kanzenbach@...utronix.de>,
        Holger Assmann <h.assmann@...gutronix.de>,
        Yannick Vignon <yannick.vignon@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Xiaoliang Yang <xiaoliang.yang_1@....com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        Jose Abreu <joabreu@...opsys.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Pengutronix Kernel Team <kernel@...gutronix.de>
Subject: Re: [Linux-stm32] [PATCH net] net: stmmac: allow a tc-taprio
 base-time of zero

On Tue, Nov 09, 2021 at 04:22:55PM +0200, Vladimir Oltean wrote:
> On Tue, Nov 09, 2021 at 03:19:28PM +0100, Ahmad Fatoum wrote:
> > Hello Vladimir, Kurt,
> > 
> > On 09.11.21 11:35, Vladimir Oltean wrote:
> > > On Tue, Nov 09, 2021 at 09:20:53AM +0100, Kurt Kanzenbach wrote:
> > >> Hi Vladimir,
> > >>
> > >> On Mon Nov 08 2021, Vladimir Oltean wrote:
> > >>> Commit fe28c53ed71d ("net: stmmac: fix taprio configuration when
> > >>> base_time is in the past") allowed some base time values in the past,
> > >>> but apparently not all, the base-time value of 0 (Jan 1st 1970) is still
> > >>> explicitly denied by the driver.
> > >>>
> > >>> Remove the bogus check.
> > >>>
> > >>> Fixes: b60189e0392f ("net: stmmac: Integrate EST with TAPRIO scheduler API")
> > >>> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> > >>
> > >> I've experienced the same problem and wanted to send a patch for
> > >> it. Thanks!
> > >>
> > >> Reviewed-by: Kurt Kanzenbach <kurt@...utronix.de>
> > > 
> > > Cool. So you had that patch queued up? What other stmmac patches do you
> > > have queued up? :) Do you have a fix for the driver setting the PTP time
> > > every time when SIOCSHWTSTAMP is called? This breaks the UTC-to-TAI
> > > offset established by phc2sys and it takes a few seconds to readjust,
> > > which is very annoying.
> > 
> > Sounds like the same issue in:
> > https://lore.kernel.org/netdev/20201216113239.2980816-1-h.assmann@pengutronix.de/
> > 
> > Cheers,
> > Ahmad
> 
> Indeed. Was there a v2 to that?

FWIW I've applied that patch and made a few fixups according to my
liking, and it works fine. I can resend it myself if there aren't any
volunteers from Pengutronix.