linux-kernel - Re: [PATCH V1 1/2] mm/damon: Unified access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20211110125959.18141-1-sj@kernel.org>
Date:   Wed, 10 Nov 2021 12:59:59 +0000
From:   SeongJae Park <sj@...nel.org>
To:     Xin Hao <xhao@...ux.alibaba.com>
Cc:     sjpark@...zon.de, akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V1 1/2] mm/damon: Unified access_check function naming rules

On Wed, 10 Nov 2021 20:13:13 +0800 Xin Hao <xhao@...ux.alibaba.com> wrote:

> In damon/paddr.c file, two functions names start with underscore,
> 	static void __damon_pa_prepare_access_check(struct damon_ctx *ctx,
> 			struct damon_region *r)
> 	static void __damon_pa_prepare_access_check(struct damon_ctx *ctx,
> 			struct damon_region *r)
> In damon/vaddr.c file, there are also two functions with the same function,
> 	static void damon_va_prepare_access_check(struct damon_ctx *ctx,
> 			struct mm_struct *mm, struct damon_region *r)
> 	static void damon_va_check_access(struct damon_ctx *ctx,
> 			struct mm_struct *mm, struct damon_region *r)
> 
> It makes sense to keep consistent, and it is not easy to be confused with
> the function that call them.
> 
> Signed-off-by: Xin Hao <xhao@...ux.alibaba.com>

Reviewed-by: SeongJae Park <sj@...nel.org>


Thanks,
SJ

[...]