linux-kernel - Re: [PATCH] drm/bridge: parade-ps8640: Assign drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <feb2ebef-5859-db38-8243-a4396770d736@collabora.com>
Date:   Wed, 10 Nov 2021 15:02:15 +0200
From:   Dafna Hirschfeld <dafna.hirschfeld@...labora.com>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>, a.hajda@...sung.com
Cc:     narmstrong@...libre.com, robert.foss@...aro.org,
        Laurent.pinchart@...asonboard.com, jonas@...boo.se,
        jernej.skrabec@...il.com, airlied@...ux.ie, daniel@...ll.ch,
        dri-devel@...ts.freedesktop.org, kernel@...labora.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: parade-ps8640: Assign drm_device to dp aux
 channel



On 04.11.21 12:20, AngeloGioacchino Del Regno wrote:
> As it was done with other bridge drivers and to solve a warning coming
> from drm_dp_aux_register(), add a backpointer to drm_device in the
> drm_dp_aux that we're registering.
> 

it is common to dump the exact warning in the commit log so people can locate it later.
Maybe also add 'Fixes' tag?

apart of that

Reviewed-by: Dafna Hirschfeld <dafna.hirschfeld@...labora.com>


> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> ---
>   drivers/gpu/drm/bridge/parade-ps8640.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
> index 191cc196c9d1..20d8e606d543 100644
> --- a/drivers/gpu/drm/bridge/parade-ps8640.c
> +++ b/drivers/gpu/drm/bridge/parade-ps8640.c
> @@ -455,6 +455,7 @@ static int ps8640_bridge_attach(struct drm_bridge *bridge,
>   		goto err_dsi_attach;
>   	}
>   
> +	ps_bridge->aux.drm_dev = bridge->dev;
>   	ret = drm_dp_aux_register(&ps_bridge->aux);
>   	if (ret) {
>   		dev_err(dev, "failed to register DP AUX channel: %d\n", ret);
>