linux-kernel - Re: [PATCH v2] of/unittest: Disable new dtc node_name_vs_property_name and interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 10 Nov 2021 16:35:55 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Rob Herring <robh@...nel.org>
Cc:     devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Frank Rowand <frowand.list@...il.com>
Subject: Re: [PATCH v2] of/unittest: Disable new dtc
 node_name_vs_property_name and interrupt_map warnings

On Wed, Nov 10, 2021 at 07:48:16AM -0600, Rob Herring wrote:
> On Wed, Nov 10, 2021 at 7:31 AM Greg KH <gregkh@...uxfoundation.org> wrote:
> >
> > On Thu, Oct 28, 2021 at 08:04:23AM -0500, Rob Herring wrote:
> > > The unittest dtbs have various intentional errors which cause warnings.
> > > With the latest dtc sync to v1.6.1-19-g0a3a9d3449c8, we need to disable
> > > some new checks: node_name_vs_property_name and interrupt_map warnings.
> > > These warnings are also generated for static_base_1.dtb, so add
> > > DTC_FLAGS for it.
> > >
> > > Note that the interrupt_map warnings only appear once interrupt_provider
> > > warning is re-enabled globally.
> > >
> > > drivers/of/unittest-data/tests-interrupts.dtsi:32.26-35.6: Warning (interrupt_map): /testcase-data/interrupts/intmap1: Missing '#address-cells' in interrupt-map provider
> > >
> > > Fixes: e76187b9792e ("scripts/dtc: Update to upstream version v1.6.1-19-g0a3a9d3449c8")
> > > Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> > > Cc: Frank Rowand <frowand.list@...il.com>
> > > Signed-off-by: Rob Herring <robh@...nel.org>
> > > ---
> > >  drivers/of/unittest-data/Makefile | 8 +++++++-
> > >  1 file changed, 7 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/of/unittest-data/Makefile b/drivers/of/unittest-data/Makefile
> > > index a5d2d9254b2c..fbded24c608c 100644
> > > --- a/drivers/of/unittest-data/Makefile
> > > +++ b/drivers/of/unittest-data/Makefile
> > > @@ -37,7 +37,9 @@ DTC_FLAGS_overlay_base += -@
> > >  DTC_FLAGS_testcases += -@
> > >
> > >  # suppress warnings about intentional errors
> > > -DTC_FLAGS_testcases += -Wno-interrupts_property
> > > +DTC_FLAGS_testcases += -Wno-interrupts_property \
> > > +     -Wno-node_name_vs_property_name \
> > > +     -Wno-interrupt_map
> > >
> > >  # Apply overlays statically with fdtoverlay.  This is a build time test that
> > >  # the overlays can be applied successfully by fdtoverlay.  This does not
> > > @@ -82,6 +84,10 @@ apply_static_overlay_1 := overlay_0.dtbo \
> > >
> > >  apply_static_overlay_2 := overlay.dtbo
> > >
> > > +DTC_FLAGS_static_base_1 += -Wno-interrupts_property \
> > > +     -Wno-node_name_vs_property_name \
> > > +     -Wno-interrupt_map
> > > +
> > >  static_test_1-dtbs := static_base_1.dtb $(apply_static_overlay_1)
> > >  static_test_2-dtbs := static_base_2.dtb $(apply_static_overlay_2)
> > >
> > > --
> > > 2.32.0
> > >
> >
> > Note this commit in Linus's tree breaks clang-based systems with the
> > following build errors:
> >         FATAL ERROR: Unrecognized check name "interrupt_map"
> >         FATAL ERROR: Unrecognized check name "node_name_vs_property_name"
> >
> > Any thoughts about what to do?
> 
> I don't think it has anything to do with clang. These messages come
> from dtc and there's not any 'test the options are supported'
> mechanism for new options. It looks like the dtc update referenced in
> Fixes is missing or dtc is stale. There's no error in kernelci[1].

Ah, yes, turns out that Android is building their kernel with an old
version of dtc.  So that's the issue here, I'll go work to fix that
up...

Sorry for the noise.

thanks,

greg k-h