linux-kernel - [leon-rdma:devlink 4/16] drivers/net/ethernet/marvell/prestera/prestera_devlink.c:425:6: error: unused variable 'err'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 11 Nov 2021 00:02:26 +0800
From:   kernel test robot <lkp@...el.com>
To:     Leon Romanovsky <leonro@...dia.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [leon-rdma:devlink 4/16]
 drivers/net/ethernet/marvell/prestera/prestera_devlink.c:425:6: error:
 unused variable 'err'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git devlink
head:   75088f5c533815580092fd7dca787c06e75ba7ba
commit: 3c73f365d81cf18adf846a4ef36e605ad52acd0a [4/16] devlink: Clean registration of devlink port
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git/commit/?id=3c73f365d81cf18adf846a4ef36e605ad52acd0a
        git remote add leon-rdma https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git
        git fetch --no-tags leon-rdma devlink
        git checkout 3c73f365d81cf18adf846a4ef36e605ad52acd0a
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/net/ethernet/marvell/prestera/prestera_devlink.c: In function 'prestera_devlink_port_register':
>> drivers/net/ethernet/marvell/prestera/prestera_devlink.c:425:6: error: unused variable 'err' [-Werror=unused-variable]
     425 |  int err;
         |      ^~~
   cc1: all warnings being treated as errors
--
   drivers/net/ethernet/intel/ice/ice_devlink.c: In function 'ice_devlink_create_pf_port':
>> drivers/net/ethernet/intel/ice/ice_devlink.c:501:17: error: variable 'dev' set but not used [-Werror=unused-but-set-variable]
     501 |  struct device *dev;
         |                 ^~~
   drivers/net/ethernet/intel/ice/ice_devlink.c: In function 'ice_devlink_create_vf_port':
   drivers/net/ethernet/intel/ice/ice_devlink.c:550:17: error: variable 'dev' set but not used [-Werror=unused-but-set-variable]
     550 |  struct device *dev;
         |                 ^~~
   cc1: all warnings being treated as errors


vim +/err +425 drivers/net/ethernet/marvell/prestera/prestera_devlink.c

34dd1710f5a3c9 Vadym Kochan    2020-09-16  419  
34dd1710f5a3c9 Vadym Kochan    2020-09-16  420  int prestera_devlink_port_register(struct prestera_port *port)
34dd1710f5a3c9 Vadym Kochan    2020-09-16  421  {
34dd1710f5a3c9 Vadym Kochan    2020-09-16  422  	struct prestera_switch *sw = port->sw;
34dd1710f5a3c9 Vadym Kochan    2020-09-16  423  	struct devlink *dl = priv_to_devlink(sw);
34dd1710f5a3c9 Vadym Kochan    2020-09-16  424  	struct devlink_port_attrs attrs = {};
34dd1710f5a3c9 Vadym Kochan    2020-09-16 @425  	int err;
34dd1710f5a3c9 Vadym Kochan    2020-09-16  426  
34dd1710f5a3c9 Vadym Kochan    2020-09-16  427  	attrs.flavour = DEVLINK_PORT_FLAVOUR_PHYSICAL;
34dd1710f5a3c9 Vadym Kochan    2020-09-16  428  	attrs.phys.port_number = port->fp_id;
34dd1710f5a3c9 Vadym Kochan    2020-09-16  429  	attrs.switch_id.id_len = sizeof(sw->id);
34dd1710f5a3c9 Vadym Kochan    2020-09-16  430  	memcpy(attrs.switch_id.id, &sw->id, attrs.switch_id.id_len);
34dd1710f5a3c9 Vadym Kochan    2020-09-16  431  
34dd1710f5a3c9 Vadym Kochan    2020-09-16  432  	devlink_port_attrs_set(&port->dl_port, &attrs);
34dd1710f5a3c9 Vadym Kochan    2020-09-16  433  
3c73f365d81cf1 Leon Romanovsky 2021-11-03  434  	devlink_port_register(dl, &port->dl_port, port->fp_id);
34dd1710f5a3c9 Vadym Kochan    2020-09-16  435  	return 0;
34dd1710f5a3c9 Vadym Kochan    2020-09-16  436  }
34dd1710f5a3c9 Vadym Kochan    2020-09-16  437  

:::::: The code at line 425 was first introduced by commit
:::::: 34dd1710f5a3c9a7dc78e1ff6de69a19d407db25 net: marvell: prestera: Add basic devlink support

:::::: TO: Vadym Kochan <vadym.kochan@...ision.eu>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (66068 bytes)