linux-kernel - Re: [PATCH] drm/amdgpu: remove unneeded variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 10 Nov 2021 11:38:18 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     CGEL <cgel.zte@...il.com>
Cc:     "Quan, Evan" <evan.quan@....com>,
        "Lazar, Lijo" <lijo.lazar@....com>,
        Chengming Gui <Jack.Gui@....com>,
        Dave Airlie <airlied@...ux.ie>, Zeal Robot <zealci@....com.cn>,
        xinhui pan <Xinhui.Pan@....com>,
        LKML <linux-kernel@...r.kernel.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        "Tuikov, Luben" <luben.tuikov@....com>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        "Deucher, Alexander" <alexander.deucher@....com>,
        ran jianping <ran.jianping@....com.cn>,
        Kenneth Feng <kenneth.feng@....com>,
        Christian Koenig <christian.koenig@....com>
Subject: Re: [PATCH] drm/amdgpu: remove unneeded variable

Applied.  Thanks!

Alex

On Wed, Nov 10, 2021 at 12:53 AM <cgel.zte@...il.com> wrote:
>
> From: ran jianping <ran.jianping@....com.cn>
>
> Fix the following coccicheck review:
> ./drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c:1174:14-18
> :Unneeded variable
>
> Remove unneeded variable used to store return value.
>
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: ran jianping <ran.jianping@....com.cn>
> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
> index a4108025fe29..b0bb389185d5 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
> @@ -1171,7 +1171,7 @@ static int sienna_cichlid_force_clk_levels(struct smu_context *smu,
>                                    enum smu_clk_type clk_type, uint32_t mask)
>  {
>         struct amdgpu_device *adev = smu->adev;
> -       int ret = 0, size = 0;
> +       int ret = 0;
>         uint32_t soft_min_level = 0, soft_max_level = 0, min_freq = 0, max_freq = 0;
>
>         soft_min_level = mask ? (ffs(mask) - 1) : 0;
> @@ -1216,7 +1216,7 @@ static int sienna_cichlid_force_clk_levels(struct smu_context *smu,
>         if ((clk_type == SMU_GFXCLK) || (clk_type == SMU_SCLK))
>                 amdgpu_gfx_off_ctrl(adev, true);
>
> -       return size;
> +       return 0;
>  }
>
>  static int sienna_cichlid_populate_umd_state_clk(struct smu_context *smu)
> --
> 2.25.1
>