linux-kernel - Re: [PATCH 1/2] SPI: Add SPI driver for Sunplus SP7021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vc8DUyHxhTm2RrdoSmcx9EXjDJvm3FDBRD7Lm4WA5sQ+A@mail.gmail.com>
Date:   Wed, 10 Nov 2021 18:46:31 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     "LH.Kuo" <lhjeff911@...il.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Rob Herring <robh+dt@...nel.org>,
        linux-spi <linux-spi@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        dvorkin@...bo.com, qinjian@...lus1.com, wells.lu@...plus.com,
        "LH.Kuo" <lh.kuo@...plus.com>
Subject: Re: [PATCH 1/2] SPI: Add SPI driver for Sunplus SP7021

On Mon, Nov 1, 2021 at 8:37 PM Mark Brown <broonie@...nel.org> wrote:
> On Mon, Nov 01, 2021 at 02:18:44PM +0800, LH.Kuo wrote:
>
> > Add SPI driver for Sunplus SP7021.
>
> In general it looks like this needs quite a bit of a refresh for
> mainline - a lot of it looks to be a combination of minor, easily
> fixable things and stylistic issues which make things hard to follow but
> I think there are some more substantial things going on here as well.

Just looked at their UART driver submission with the similar idea in mind.
Asked them to shrink the size 1.5-2x times. I believe this is possible
(and yes, I already saw a new version which is better, but can be
cleaned up more).

Folks, try again for all your drivers for this SoC.

-- 
With Best Regards,
Andy Shevchenko