linux-kernel - drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c:363:62: warning: format specifies type 'char' but the argument has type 'int'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 10 Nov 2021 11:53:02 +0800
From:   kernel test robot <lkp@...el.com>
To:     Edwin Peer <edwin.peer@...adcom.com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org,
        Michael Chan <michael.chan@...adcom.com>
Subject: drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c:363:62: warning:
 format specifies type 'char' but the argument has type 'int'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   cb690f5238d71f543f4ce874aa59237cf53a877c
commit: 3c4153394e2c749b415947b86eb560114ec0f64d bnxt_en: implement firmware live patching
date:   12 days ago
config: i386-randconfig-a002-20211109 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project f3798ad5fa845771846599f3c088016e3aef800c)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=3c4153394e2c749b415947b86eb560114ec0f64d
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 3c4153394e2c749b415947b86eb560114ec0f64d
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c:363:62: warning: format specifies type 'char' but the argument has type 'int' [-Wformat]
                   netdev_err(bp->dev, "Unexpected live patch error: %hhd\n", err);
                                                                     ~~~~     ^~~
                                                                     %d
   1 warning generated.


vim +363 drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c

   325	
   326	static int bnxt_dl_info_get(struct devlink *dl, struct devlink_info_req *req,
   327				    struct netlink_ext_ack *extack);
   328	
   329	static void
   330	bnxt_dl_livepatch_report_err(struct bnxt *bp, struct netlink_ext_ack *extack,
   331				     struct hwrm_fw_livepatch_output *resp)
   332	{
   333		int err = ((struct hwrm_err_output *)resp)->cmd_err;
   334	
   335		switch (err) {
   336		case FW_LIVEPATCH_CMD_ERR_CODE_INVALID_OPCODE:
   337			netdev_err(bp->dev, "Illegal live patch opcode");
   338			NL_SET_ERR_MSG_MOD(extack, "Invalid opcode");
   339			break;
   340		case FW_LIVEPATCH_CMD_ERR_CODE_NOT_SUPPORTED:
   341			NL_SET_ERR_MSG_MOD(extack, "Live patch operation not supported");
   342			break;
   343		case FW_LIVEPATCH_CMD_ERR_CODE_NOT_INSTALLED:
   344			NL_SET_ERR_MSG_MOD(extack, "Live patch not found");
   345			break;
   346		case FW_LIVEPATCH_CMD_ERR_CODE_NOT_PATCHED:
   347			NL_SET_ERR_MSG_MOD(extack,
   348					   "Live patch deactivation failed. Firmware not patched.");
   349			break;
   350		case FW_LIVEPATCH_CMD_ERR_CODE_AUTH_FAIL:
   351			NL_SET_ERR_MSG_MOD(extack, "Live patch not authenticated");
   352			break;
   353		case FW_LIVEPATCH_CMD_ERR_CODE_INVALID_HEADER:
   354			NL_SET_ERR_MSG_MOD(extack, "Incompatible live patch");
   355			break;
   356		case FW_LIVEPATCH_CMD_ERR_CODE_INVALID_SIZE:
   357			NL_SET_ERR_MSG_MOD(extack, "Live patch has invalid size");
   358			break;
   359		case FW_LIVEPATCH_CMD_ERR_CODE_ALREADY_PATCHED:
   360			NL_SET_ERR_MSG_MOD(extack, "Live patch already applied");
   361			break;
   362		default:
 > 363			netdev_err(bp->dev, "Unexpected live patch error: %hhd\n", err);
   364			NL_SET_ERR_MSG_MOD(extack, "Failed to activate live patch");
   365			break;
   366		}
   367	}
   368	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (35380 bytes)