| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 11 Nov 2021 10:36:20 +0800
From: Muchun Song <songmuchun@...edance.com>
To: Mina Almasry <almasrymina@...gle.com>
Cc: Mike Kravetz <mike.kravetz@...cle.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Shuah Khan <shuah@...nel.org>,
Miaohe Lin <linmiaohe@...wei.com>,
Oscar Salvador <osalvador@...e.de>,
Michal Hocko <mhocko@...e.com>,
David Rientjes <rientjes@...gle.com>,
Shakeel Butt <shakeelb@...gle.com>, Jue Wang <juew@...gle.com>,
Yang Yao <ygyao@...gle.com>, Joanna Li <joannali@...gle.com>,
Cannon Matthews <cannonmatthews@...gle.com>,
Linux Memory Management List <linux-mm@...ck.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6] hugetlb: Add hugetlb.*.numa_stat file
On Thu, Nov 11, 2021 at 9:50 AM Mina Almasry <almasrymina@...gle.com> wrote:
>
> For hugetlb backed jobs/VMs it's critical to understand the numa
> information for the memory backing these jobs to deliver optimal
> performance.
>
> Currently this technically can be queried from /proc/self/numa_maps, but
> there are significant issues with that. Namely:
> 1. Memory can be mapped or unmapped.
> 2. numa_maps are per process and need to be aggregated across all
> processes in the cgroup. For shared memory this is more involved as
> the userspace needs to make sure it doesn't double count shared
> mappings.
> 3. I believe querying numa_maps needs to hold the mmap_lock which adds
> to the contention on this lock.
>
> For these reasons I propose simply adding hugetlb.*.numa_stat file,
> which shows the numa information of the cgroup similarly to
> memory.numa_stat.
>
> On cgroup-v2:
> cat /sys/fs/cgroup/unified/test/hugetlb.2MB.numa_stat
> total=2097152 N0=2097152 N1=0
>
> On cgroup-v1:
> cat /sys/fs/cgroup/hugetlb/test/hugetlb.2MB.numa_stat
> total=2097152 N0=2097152 N1=0
> hierarichal_total=2097152 N0=2097152 N1=0
>
> This patch was tested manually by allocating hugetlb memory and querying
> the hugetlb.*.numa_stat file of the cgroup and its parents.
> 
> Cc: Mike Kravetz <mike.kravetz@...cle.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Shuah Khan <shuah@...nel.org>
> Cc: Miaohe Lin <linmiaohe@...wei.com>
> Cc: Oscar Salvador <osalvador@...e.de>
> Cc: Michal Hocko <mhocko@...e.com>
> Cc: Muchun Song <songmuchun@...edance.com>
> Cc: David Rientjes <rientjes@...gle.com>
> Cc: Shakeel Butt <shakeelb@...gle.com>
> Cc: Jue Wang <juew@...gle.com>
> Cc: Yang Yao <ygyao@...gle.com>
> Cc: Joanna Li <joannali@...gle.com>
> Cc: Cannon Matthews <cannonmatthews@...gle.com>
> Cc: linux-mm@...ck.org
> Cc: linux-kernel@...r.kernel.org
>
> Signed-off-by: Mina Almasry <almasrymina@...gle.com>
>
> ---
>
> Changes in v6:
> - Changed usage from unsigned long to atomic_long_t
>
> Changes in v5:
> - Fixed commit message typo.
> - Fixed per node usage documentation to be in pages.
> - Removed unnecessary h_cg check.
>
> Changes in v4:
> - Removed unnecessary braces.
> - usage is now counted in pages instead of bytes.
> - Reverted unneeded changes to write_to_hugetlbfs.c
>
> Changes in v3:
> - Fixed typos (sorry!)
> - Used conventional locations for cgroups mount points in docs/commit
> message.
> - Updated docs.
> - Handle kzalloc_node failure, and proper deallocation of per node data.
> - Use struct_size() to calculate the struct size.
> - Use nr_node_ids instead of MAX_NUMNODES.
> - Updated comments per multi-line comment pattern.
>
> Changes in v2:
> - Fix warning Reported-by: kernel test robot <lkp@...el.com>
> ---
> .../admin-guide/cgroup-v1/hugetlb.rst | 4 +
> Documentation/admin-guide/cgroup-v2.rst | 5 +
> include/linux/hugetlb.h | 4 +-
> include/linux/hugetlb_cgroup.h | 7 ++
> mm/hugetlb_cgroup.c | 118 ++++++++++++++++--
> 5 files changed, 127 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/admin-guide/cgroup-v1/hugetlb.rst b/Documentation/admin-guide/cgroup-v1/hugetlb.rst
> index 338f2c7d7a1c..0fa724d82abb 100644
> --- a/Documentation/admin-guide/cgroup-v1/hugetlb.rst
> +++ b/Documentation/admin-guide/cgroup-v1/hugetlb.rst
> @@ -29,12 +29,14 @@ Brief summary of control files::
> hugetlb.<hugepagesize>.max_usage_in_bytes # show max "hugepagesize" hugetlb usage recorded
> hugetlb.<hugepagesize>.usage_in_bytes # show current usage for "hugepagesize" hugetlb
> hugetlb.<hugepagesize>.failcnt # show the number of allocation failure due to HugeTLB usage limit
> + hugetlb.<hugepagesize>.numa_stat # show the numa information of the hugetlb memory charged to this cgroup
>
> For a system supporting three hugepage sizes (64k, 32M and 1G), the control
> files include::
>
> hugetlb.1GB.limit_in_bytes
> hugetlb.1GB.max_usage_in_bytes
> + hugetlb.1GB.numa_stat
> hugetlb.1GB.usage_in_bytes
> hugetlb.1GB.failcnt
> hugetlb.1GB.rsvd.limit_in_bytes
> @@ -43,6 +45,7 @@ files include::
> hugetlb.1GB.rsvd.failcnt
> hugetlb.64KB.limit_in_bytes
> hugetlb.64KB.max_usage_in_bytes
> + hugetlb.64KB.numa_stat
> hugetlb.64KB.usage_in_bytes
> hugetlb.64KB.failcnt
> hugetlb.64KB.rsvd.limit_in_bytes
> @@ -51,6 +54,7 @@ files include::
> hugetlb.64KB.rsvd.failcnt
> hugetlb.32MB.limit_in_bytes
> hugetlb.32MB.max_usage_in_bytes
> + hugetlb.32MB.numa_stat
> hugetlb.32MB.usage_in_bytes
> hugetlb.32MB.failcnt
> hugetlb.32MB.rsvd.limit_in_bytes
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 4d8c27eca96b..356847f8f008 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -2252,6 +2252,11 @@ HugeTLB Interface Files
> are local to the cgroup i.e. not hierarchical. The file modified event
> generated on this file reflects only the local events.
>
> + hugetlb.<hugepagesize>.numa_stat
> + Similar to memory.numa_stat, it shows the numa information of the
> + hugetlb pages of <hugepagesize> in this cgroup. Only active in
> + use hugetlb pages are included. The per-node values are in bytes.
> +
> Misc
> ----
>
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index 1faebe1cd0ed..0445faaa636e 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -613,8 +613,8 @@ struct hstate {
> #endif
> #ifdef CONFIG_CGROUP_HUGETLB
> /* cgroup control files */
> - struct cftype cgroup_files_dfl[7];
> - struct cftype cgroup_files_legacy[9];
> + struct cftype cgroup_files_dfl[8];
> + struct cftype cgroup_files_legacy[10];
> #endif
> char name[HSTATE_NAME_LEN];
> };
> diff --git a/include/linux/hugetlb_cgroup.h b/include/linux/hugetlb_cgroup.h
> index c137396129db..13aa0210ff70 100644
> --- a/include/linux/hugetlb_cgroup.h
> +++ b/include/linux/hugetlb_cgroup.h
> @@ -36,6 +36,11 @@ enum hugetlb_memory_event {
> HUGETLB_NR_MEMORY_EVENTS,
> };
>
> +struct hugetlb_cgroup_per_node {
> + /* hugetlb usage in pages over all hstates. */
> + atomic_long_t usage[HUGE_MAX_HSTATE];
Why do you use atomic? IIUC, 'usage' is always
increased/decreased under hugetlb_lock except
hugetlb_cgroup_read_numa_stat() which is always
reading it. So I think WRITE_ONCE/READ_ONCE
is enough.
Thanks.
> +};
> +
> struct hugetlb_cgroup {
> struct cgroup_subsys_state css;
>
> @@ -57,6 +62,8 @@ struct hugetlb_cgroup {
>
> /* Handle for "hugetlb.events.local" */
> struct cgroup_file events_local_file[HUGE_MAX_HSTATE];
> +
> + struct hugetlb_cgroup_per_node *nodeinfo[];
> };
>
> static inline struct hugetlb_cgroup *
> diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c
> index 5383023d0cca..be1f25a9ba28 100644
> --- a/mm/hugetlb_cgroup.c
> +++ b/mm/hugetlb_cgroup.c
> @@ -126,29 +126,58 @@ static void hugetlb_cgroup_init(struct hugetlb_cgroup *h_cgroup,
> }
> }
>
> +static void hugetlb_cgroup_free(struct hugetlb_cgroup *h_cgroup)
> +{
> + int node;
> +
> + for_each_node(node)
> + kfree(h_cgroup->nodeinfo[node]);
> + kfree(h_cgroup);
> +}
> +
> static struct cgroup_subsys_state *
> hugetlb_cgroup_css_alloc(struct cgroup_subsys_state *parent_css)
> {
> struct hugetlb_cgroup *parent_h_cgroup = hugetlb_cgroup_from_css(parent_css);
> struct hugetlb_cgroup *h_cgroup;
> + int node;
> +
> + h_cgroup = kzalloc(struct_size(h_cgroup, nodeinfo, nr_node_ids),
> + GFP_KERNEL);
>
> - h_cgroup = kzalloc(sizeof(*h_cgroup), GFP_KERNEL);
> if (!h_cgroup)
> return ERR_PTR(-ENOMEM);
>
> if (!parent_h_cgroup)
> root_h_cgroup = h_cgroup;
>
> + /*
> + * TODO: this routine can waste much memory for nodes which will
> + * never be onlined. It's better to use memory hotplug callback
> + * function.
> + */
> + for_each_node(node) {
> + /* Set node_to_alloc to -1 for offline nodes. */
> + int node_to_alloc =
> + node_state(node, N_NORMAL_MEMORY) ? node : -1;
> + h_cgroup->nodeinfo[node] =
> + kzalloc_node(sizeof(struct hugetlb_cgroup_per_node),
> + GFP_KERNEL, node_to_alloc);
> + if (!h_cgroup->nodeinfo[node])
> + goto fail_alloc_nodeinfo;
> + }
> +
> hugetlb_cgroup_init(h_cgroup, parent_h_cgroup);
> return &h_cgroup->css;
> +
> +fail_alloc_nodeinfo:
> + hugetlb_cgroup_free(h_cgroup);
> + return ERR_PTR(-ENOMEM);
> }
>
> static void hugetlb_cgroup_css_free(struct cgroup_subsys_state *css)
> {
> - struct hugetlb_cgroup *h_cgroup;
> -
> - h_cgroup = hugetlb_cgroup_from_css(css);
> - kfree(h_cgroup);
> + hugetlb_cgroup_free(hugetlb_cgroup_from_css(css));
> }
>
> /*
> @@ -292,7 +321,9 @@ static void __hugetlb_cgroup_commit_charge(int idx, unsigned long nr_pages,
> return;
>
> __set_hugetlb_cgroup(page, h_cg, rsvd);
> - return;
> + if (!rsvd)
> + atomic_long_add(nr_pages,
> + &h_cg->nodeinfo[page_to_nid(page)]->usage[idx]);
> }
>
> void hugetlb_cgroup_commit_charge(int idx, unsigned long nr_pages,
> @@ -331,7 +362,9 @@ static void __hugetlb_cgroup_uncharge_page(int idx, unsigned long nr_pages,
>
> if (rsvd)
> css_put(&h_cg->css);
> -
> + else
> + atomic_long_sub(nr_pages,
> + &h_cg->nodeinfo[page_to_nid(page)]->usage[idx]);
> return;
Could you remove "return" by the way?
> }
>
> @@ -421,6 +454,61 @@ enum {
> RES_RSVD_FAILCNT,
> };
>
> +static int hugetlb_cgroup_read_numa_stat(struct seq_file *seq, void *dummy)
> +{
> + int nid;
> + struct cftype *cft = seq_cft(seq);
> + int idx = MEMFILE_IDX(cft->private);
> + bool legacy = MEMFILE_ATTR(cft->private);
> + struct hugetlb_cgroup *h_cg = hugetlb_cgroup_from_css(seq_css(seq));
> + struct cgroup_subsys_state *css;
> + unsigned long usage;
> +
> + if (legacy) {
> + /* Add up usage across all nodes for the non-hierarchical total. */
> + usage = 0;
> + for_each_node_state(nid, N_MEMORY)
> + usage += atomic_long_read(
> + &h_cg->nodeinfo[nid]->usage[idx]);
> + seq_printf(seq, "total=%lu", usage * PAGE_SIZE);
> +
> + /* Simply print the per-node usage for the non-hierarchical total. */
> + for_each_node_state(nid, N_MEMORY)
> + seq_printf(seq, " N%d=%lu", nid,
> + atomic_long_read(
> + &h_cg->nodeinfo[nid]->usage[idx]) *
> + PAGE_SIZE);
> + seq_putc(seq, '\n');
> + }
> +
> + /*
> + * The hierarchical total is pretty much the value recorded by the
> + * counter, so use that.
> + */
> + seq_printf(seq, "%stotal=%lu", legacy ? "hierarichal_" : "",
> + page_counter_read(&h_cg->hugepage[idx]) * PAGE_SIZE);
> +
> + /*
> + * For each node, transverse the css tree to obtain the hierarichal
> + * node usage.
> + */
> + for_each_node_state(nid, N_MEMORY) {
> + usage = 0;
> + rcu_read_lock();
> + css_for_each_descendant_pre(css, &h_cg->css) {
> + usage += atomic_long_read(&hugetlb_cgroup_from_css(css)
> + ->nodeinfo[nid]
> + ->usage[idx]);
> + }
> + rcu_read_unlock();
> + seq_printf(seq, " N%d=%lu", nid, usage * PAGE_SIZE);
> + }
> +
> + seq_putc(seq, '\n');
> +
> + return 0;
> +}
> +
> static u64 hugetlb_cgroup_read_u64(struct cgroup_subsys_state *css,
> struct cftype *cft)
> {
> @@ -671,8 +759,14 @@ static void __init __hugetlb_cgroup_file_dfl_init(int idx)
> events_local_file[idx]);
> cft->flags = CFTYPE_NOT_ON_ROOT;
>
> - /* NULL terminate the last cft */
> + /* Add the numa stat file */
> cft = &h->cgroup_files_dfl[6];
> + snprintf(cft->name, MAX_CFTYPE_NAME, "%s.numa_stat", buf);
> + cft->seq_show = hugetlb_cgroup_read_numa_stat;
> + cft->flags = CFTYPE_NOT_ON_ROOT;
> +
> + /* NULL terminate the last cft */
> + cft = &h->cgroup_files_dfl[7];
> memset(cft, 0, sizeof(*cft));
>
> WARN_ON(cgroup_add_dfl_cftypes(&hugetlb_cgrp_subsys,
> @@ -742,8 +836,14 @@ static void __init __hugetlb_cgroup_file_legacy_init(int idx)
> cft->write = hugetlb_cgroup_reset;
> cft->read_u64 = hugetlb_cgroup_read_u64;
>
> + /* Add the numa stat file */
> + cft = &h->cgroup_files_dfl[8];
> + snprintf(cft->name, MAX_CFTYPE_NAME, "%s.numa_stat", buf);
> + cft->private = MEMFILE_PRIVATE(idx, 1);
> + cft->seq_show = hugetlb_cgroup_read_numa_stat;
> +
> /* NULL terminate the last cft */
> - cft = &h->cgroup_files_legacy[8];
> + cft = &h->cgroup_files_legacy[9];
> memset(cft, 0, sizeof(*cft));
>
> WARN_ON(cgroup_add_legacy_cftypes(&hugetlb_cgrp_subsys,
> --
> 2.34.0.rc0.344.g81b53c2807-goog
Powered by blists - more mailing lists