linux-kernel - RE: [PATCH] rtw89: remove unneeded variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 Nov 2021 05:19:19 +0000
From:   Pkshih <pkshih@...ltek.com>
To:     "cgel.zte@...il.com" <cgel.zte@...il.com>,
        "kvalo@...eaurora.org" <kvalo@...eaurora.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "deng.changcheng@....com.cn" <deng.changcheng@....com.cn>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Zeal Robot <zealci@....com.cn>
Subject: RE: [PATCH] rtw89: remove unneeded variable


> -----Original Message-----
> From: cgel.zte@...il.com <cgel.zte@...il.com>
> Sent: Wednesday, November 10, 2021 8:12 PM
> To: kvalo@...eaurora.org
> Cc: davem@...emloft.net; kuba@...nel.org; deng.changcheng@....com.cn; Pkshih <pkshih@...ltek.com>;
> linux-wireless@...r.kernel.org; netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Zeal Robot
> <zealci@....com.cn>
> Subject: [PATCH] rtw89: remove unneeded variable
> 
> From: Changcheng Deng <deng.changcheng@....com.cn>
> 
> Fix the following coccicheck review:
> ./drivers/net/wireless/realtek/rtw89/mac.c: 1096: 5-8: Unneeded variable
> 
> Remove unneeded variable used to store return value.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@....com.cn>

Acked-by: Ping-Ke Shih <pkshih@...ltek.com>

> ---
>  drivers/net/wireless/realtek/rtw89/mac.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireless/realtek/rtw89/mac.c
> index 0171a5a7b1de..b93ac242b305 100644
> --- a/drivers/net/wireless/realtek/rtw89/mac.c
> +++ b/drivers/net/wireless/realtek/rtw89/mac.c
> @@ -1093,7 +1093,6 @@ static int cmac_func_en(struct rtw89_dev *rtwdev, u8 mac_idx, bool en)
>  static int dmac_func_en(struct rtw89_dev *rtwdev)
>  {
>  	u32 val32;
> -	u32 ret = 0;
> 
>  	val32 = (B_AX_MAC_FUNC_EN | B_AX_DMAC_FUNC_EN | B_AX_MAC_SEC_EN |
>  		 B_AX_DISPATCHER_EN | B_AX_DLE_CPUIO_EN | B_AX_PKT_IN_EN |
> @@ -1107,7 +1106,7 @@ static int dmac_func_en(struct rtw89_dev *rtwdev)
>  		 B_AX_WD_RLS_CLK_EN);
>  	rtw89_write32(rtwdev, R_AX_DMAC_CLK_EN, val32);
> 
> -	return ret;
> +	return 0;
>  }
> 
>  static int chip_func_en(struct rtw89_dev *rtwdev)
> --
> 2.25.1