linux-kernel - Re: [PATCH] scsi: ufs: ufs-mediatek: add put_device() after of_find_device_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 Nov 2021 13:41:24 +0800
From:   Peter Wang <peter.wang@...iatek.com>
To:     <cgel.zte@...il.com>, <stanley.chu@...iatek.com>
CC:     <alim.akhtar@...sung.com>, <avri.altman@....com>,
        <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>,
        <matthias.bgg@...il.com>, <linux-scsi@...r.kernel.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        Ye Guojin <ye.guojin@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] scsi: ufs: ufs-mediatek: add put_device() after
 of_find_device_by_node()


On 11/10/21 6:51 PM, cgel.zte@...il.com wrote:
> From: Ye Guojin <ye.guojin@....com.cn>
>
> This was found by coccicheck:
> ./drivers/scsi/ufs/ufs-mediatek.c, 211, 1-7, ERROR missing put_device;
> call of_find_device_by_node on line 1185, but without a corresponding
> object release within this function.
>
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Ye Guojin <ye.guojin@....com.cn>
> ---
>   drivers/scsi/ufs/ufs-mediatek.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
> index fc5b214347b3..5393b5c9dd9c 100644
> --- a/drivers/scsi/ufs/ufs-mediatek.c
> +++ b/drivers/scsi/ufs/ufs-mediatek.c
> @@ -1189,6 +1189,7 @@ static int ufs_mtk_probe(struct platform_device *pdev)
>   	}
>   	link = device_link_add(dev, &reset_pdev->dev,
>   		DL_FLAG_AUTOPROBE_CONSUMER);
> +	put_device(&reset_pdev->dev);

Thanks for fix this missing.
Reviewed-by: Peter Wang <peter.wang@...iatek.com>

>   	if (!link) {
>   		dev_notice(dev, "add reset device_link fail\n");
>   		goto skip_reset;