linux-kernel - Re: [PATCH] firmware: export x86_64 platform flash bios region via sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YYy7QZGKeEEfI1mH@lahna>
Date:   Thu, 11 Nov 2021 08:42:09 +0200
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Mauro Lima <mauro.lima@...ypsium.com>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Hans-Gert Dahmen <hans-gert.dahmen@...u.ne>,
        Greg KH <gregkh@...uxfoundation.org>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Philipp Deppenwiese <philipp.deppenwiese@...u.ne>,
        Richard Hughes <hughsient@...il.com>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH] firmware: export x86_64 platform flash bios region via
 sysfs

Hi,

On Wed, Nov 10, 2021 at 02:37:56PM -0300, Mauro Lima wrote:
> > Try again to collaborate with Intel SPI driver author(s) /
> > maintainer(s) by sending the proposal that may work.
> 
> The proposal I sent makes the driver work only with read ops, but that
> was not the issue with this driver. The issue was something related to
> a status register and this was fixed. So if there is no issue with
> write/erase ops, the bug was fixed and there is no intention to remove
> the tag. What kind of proposal are we talking about?

I think we discussed this previously already but in any case, instead of
removing the tag from the "main" driver, we can make certain "safe"
parts of the driver available without that tag. That would allow you to
read the things the controller exposes and allow distros safely include
the driver too. By "safe" parts, I mean the information available
through the SPI flash controller without actually sending commands to
the flash chip. I think this is the information everybody (on this
thread at least) is interested in. Unless I'm mistaken - I did not check
the original patch. If that's not enough we can possibly expand it to
cover the controllers that only use hardware sequencer since they
operate on a certain limited set of ops that should not break anything
accidentally.