linux-kernel - Re: [PATCH v2 11/23] x86,xen: Remove .fixup usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 Nov 2021 08:20:13 +0100
From:   Juergen Gross <jgross@...e.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org, jpoimboe@...hat.com,
        mark.rutland@....com, dvyukov@...gle.com, seanjc@...gle.com,
        pbonzini@...hat.com, mbenes@...e.cz
Subject: Re: [PATCH v2 11/23] x86,xen: Remove .fixup usage

On 10.11.21 17:17, Peter Zijlstra wrote:
> On Wed, Nov 10, 2021 at 01:52:57PM +0100, Juergen Gross wrote:
>> On 10.11.21 13:46, Peter Zijlstra wrote:
>>> On Wed, Nov 10, 2021 at 12:00:39PM +0100, Peter Zijlstra wrote:
>>>> On Wed, Nov 10, 2021 at 11:35:37AM +0100, Juergen Gross wrote:
>>>
>>>>>> +		     _ASM_EXTABLE_TYPE_REG(1b, 2b, EX_TYPE_EFAUL_REG, %[ret])
>>>>>
>>>>> I guess you didn't compile that? There is a typo: s/EFAUL/EFAULT/
>>>>
>>>> Damn.. I figure that must've gotten lost in the robot spam telling me
>>>> clang can't do __cold on labels :/
>>>
>>> new patch at:
>>>
>>>     https://lkml.kernel.org/r/YYu/AteC/Wamqn46@hirez.programming.kicks-ass.net
>>>
>>
>> "not found"
> 
> Argh.. msgid contains '/' and that doesn't really work with URLs.
> 
> https://lore.kernel.org/lkml/YYu%2FAteC%2FWamqn46@hirez.programming.kicks-ass.net/
> 
> is the right url, in case you hand't yet found the actual email.

Looks good, you can add my:

Reviewed-by: Juergen Gross <jgross@...e.com>


Juergen

Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3092 bytes)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (496 bytes)