linux-kernel - Re: [PATCH v2 00/23] x86: Remove anonymous out-of-line fixups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 Nov 2021 23:55:21 -0800
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org, mark.rutland@....com,
        dvyukov@...gle.com, seanjc@...gle.com, pbonzini@...hat.com,
        mbenes@...e.cz
Subject: Re: [PATCH v2 00/23] x86: Remove anonymous out-of-line fixups

On Wed, Nov 10, 2021 at 11:01:02AM +0100, Peter Zijlstra wrote:
> Changes since v1:
> 
>  - Dropped using __cold on labels, because clang. Also gcc doesn't actually
>    generate different code with it. The intent was for the code to end up in
>    .text.cold but that doesn't happen.
>  - Fixed the vmread constraints to disallow %0 == %1.
>  - Added a asm-goto-output variant to vmx's vmread implementation.
>  - Audited Xen and FPU code and converted them from -1 to -EFAULT,
>    as a concequence EX_TYPE_NEG_REG no longer exists.
>  - Fixed the EX_DATA_*_MASK macros to include an explicit 'int' cast,
>    such that FIELD_GET() will sign-extend the top field.

I didn't (yet) get the chance to properly review the alignment math in
patches 20 & 21.  Otherwise it looks great to me.

Reviewed-by: Josh Poimboeuf <jpoimboe@...hat.com>

-- 
Josh