linux-kernel - Re: [PATCH] usb: gadget: f_fs: Use stream

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211111120636.GA11612@hu-pkondeti-hyd.qualcomm.com>
Date:   Thu, 11 Nov 2021 17:36:36 +0530
From:   Pavan Kondeti <quic_pkondeti@...cinc.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Pavankumar Kondeti <quic_pkondeti@...cinc.com>,
        <linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>,
        Felipe Balbi <balbi@...nel.org>, Jens Axboe <axboe@...nel.dk>,
        Peter Chen <peter.chen@....com>,
        Jack Pham <jackp@...eaurora.org>,
        Dean Anderson <dean@...soray.com>,
        Salah Triki <salah.triki@...il.com>,
        Andrew Gabbasov <andrew_gabbasov@...tor.com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] usb: gadget: f_fs: Use stream_open() for endpoint files

Hi Greg,

On Thu, Nov 11, 2021 at 12:38:26PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Nov 11, 2021 at 04:41:55PM +0530, Pavankumar Kondeti wrote:
> > Function fs endpoint files does not have the notion of file position.
> > So switch to stream like functionality. This allows concurrent threads
> > to be blocked in the ffs read/write operations which use ffs_mutex_lock().
> > The ffs mutex lock deploys interruptible wait. Otherwise, threads are
> > blocking for the mutex lock in __fdget_pos(). For whatever reason, ff the
> > host does not send/receive data for longer time, hung task warnings
> > are observed.
> > 
> > Change-Id: I602fa56fb5ed4c8c46e19df68c3335c4b12cae81
> 
> Always run scripts/checkpatch.pl on your patches so you do not get
> grumpy maintainers asking you to run scripts/checkpatch.pl on them...
> 
Thanks for taking a look at the patch. My bad, I have applied the patch
from a recent android tree and carry forwarded this tag. I will fix it.

Thanks,
Pavan