linux-kernel - Re: [PATCH v2] usb: gadget: f_fs: Use stream

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 Nov 2021 14:12:28 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Pavankumar Kondeti <quic_pkondeti@...cinc.com>
Cc:     linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        Felipe Balbi <balbi@...nel.org>, Jens Axboe <axboe@...nel.dk>,
        Jack Pham <jackp@...eaurora.org>,
        Peter Chen <peter.chen@....com>,
        Wesley Cheng <wcheng@...eaurora.org>,
        Andrew Gabbasov <andrew_gabbasov@...tor.com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v2] usb: gadget: f_fs: Use stream_open() for endpoint
 files

On Thu, Nov 11, 2021 at 05:45:56PM +0530, Pavankumar Kondeti wrote:
> Function fs endpoint files does not have the notion of file position.
> So switch to stream like functionality. This allows concurrent threads
> to be blocked in the ffs read/write operations which use ffs_mutex_lock().
> The ffs mutex lock deploys interruptible wait. Otherwise, threads are
> blocking for the mutex lock in __fdget_pos(). For whatever reason, ff the
> host does not send/receive data for longer time, hung task warnings
> are observed.

So the current code is broken?  What commit caused it to break?

Doesn't this change cause a change in behavior for existing userspace
tools, or will they still work as-is?

thanks,

greg k-h