linux-kernel - Re: [PATCH v1] vmscan: make drop_slab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aab58924-f1c0-4bc4-90e0-0ec6f76a5cae@redhat.com>
Date:   Thu, 11 Nov 2021 14:49:20 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Gang Li <ligang.bdlg@...edance.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] vmscan: make drop_slab_node static

On 11.11.21 07:24, Gang Li wrote:
> drop_slab_node is only used in drop_slab. So remove it's declaration from
> header file and add keyword static for it's definition.
> 
> Signed-off-by: Gang Li <ligang.bdlg@...edance.com>
> ---
>  include/linux/mm.h | 1 -
>  mm/vmscan.c        | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index a7e4a9e7d807..08b36283a57a 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -3167,7 +3167,6 @@ int drop_caches_sysctl_handler(struct ctl_table *, int, void *, size_t *,
>  #endif
>  
>  void drop_slab(void);
> -void drop_slab_node(int nid);
>  
>  #ifndef CONFIG_MMU
>  #define randomize_va_space 0
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index fb9584641ac7..b02548a32a1d 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -951,7 +951,7 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid,
>  	return freed;
>  }
>  
> -void drop_slab_node(int nid)
> +static void drop_slab_node(int nid)
>  {
>  	unsigned long freed;
>  	int shift = 0;
> 

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb