linux-kernel - Re: [PATCH 0/2] KVM: x86: Sanitize writes to MSR_KVM_PV_EOI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 11 Nov 2021 14:59:00 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>, kvm@...r.kernel.org
Cc:     Sean Christopherson <seanjc@...gle.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Li RongQing <lirongqing@...du.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] KVM: x86: Sanitize writes to MSR_KVM_PV_EOI_EN

On 11/8/21 16:28, Vitaly Kuznetsov wrote:
> This is a continuation of work started by Li RongQing with
> "[PATCH] KVM: x86: disable pv eoi if guest gives a wrong address":
> https://lore.kernel.org/kvm/1636078404-48617-1-git-send-email-lirongqing@baidu.com/
> 
> Instead of resetting 'KVM_MSR_ENABLED' when a bogus address was written to
> MSR_KVM_PV_EOI_EN I suggest we refuse to update MSR at all, this aligns
> with #GP which is being injected on such writes.
> 
> Vitaly Kuznetsov (2):
>    KVM: x86: Rename kvm_lapic_enable_pv_eoi()
>    KVM: x86: Don't update vcpu->arch.pv_eoi.msr_val when a bogus value
>      was written to MSR_KVM_PV_EOI_EN
> 
>   arch/x86/kvm/hyperv.c |  4 ++--
>   arch/x86/kvm/lapic.c  | 23 ++++++++++++++---------
>   arch/x86/kvm/lapic.h  |  2 +-
>   arch/x86/kvm/x86.c    |  2 +-
>   4 files changed, 18 insertions(+), 13 deletions(-)
> 

Queued, thanks.

Paolo