linux-kernel - drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c:79:16: error: implicit declaration of function 'readq'; did you mean 'readl'?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202111112337.1DR3myri-lkp@intel.com>
Date:   Thu, 11 Nov 2021 23:38:44 +0800
From:   kernel test robot <lkp@...el.com>
To:     Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        "Rafael J. Wysocki" <rjw@...ysocki.net>
Subject: drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c:79:16:
 error: implicit declaration of function 'readq'; did you mean 'readl'?

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   debe436e77c72fcee804fb867f275e6d31aa999c
commit: aeb58c860dc516794fdf7ff89d96ead2644d5889 thermal/drivers/int340x: processor_thermal: Suppot 64 bit RFIM responses
date:   7 days ago
config: i386-debian-10.3 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=aeb58c860dc516794fdf7ff89d96ead2644d5889
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout aeb58c860dc516794fdf7ff89d96ead2644d5889
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c: In function 'send_mbox_cmd':
>> drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c:79:16: error: implicit declaration of function 'readq'; did you mean 'readl'? [-Werror=implicit-function-declaration]
      79 |    *cmd_resp = readq((void __iomem *) (proc_priv->mmio_base + MBOX_OFFSET_DATA));
         |                ^~~~~
         |                readl
   cc1: some warnings being treated as errors


vim +79 drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c

    25	
    26	static int send_mbox_cmd(struct pci_dev *pdev, u16 cmd_id, u32 cmd_data, u64 *cmd_resp)
    27	{
    28		struct proc_thermal_device *proc_priv;
    29		u32 retries, data;
    30		int ret;
    31	
    32		mutex_lock(&mbox_lock);
    33		proc_priv = pci_get_drvdata(pdev);
    34	
    35		/* Poll for rb bit == 0 */
    36		retries = MBOX_RETRY_COUNT;
    37		do {
    38			data = readl((void __iomem *) (proc_priv->mmio_base + MBOX_OFFSET_INTERFACE));
    39			if (data & BIT_ULL(MBOX_BUSY_BIT)) {
    40				ret = -EBUSY;
    41				continue;
    42			}
    43			ret = 0;
    44			break;
    45		} while (--retries);
    46	
    47		if (ret)
    48			goto unlock_mbox;
    49	
    50		if (cmd_id == MBOX_CMD_WORKLOAD_TYPE_WRITE)
    51			writel(cmd_data, (void __iomem *) ((proc_priv->mmio_base + MBOX_OFFSET_DATA)));
    52	
    53		/* Write command register */
    54		data = BIT_ULL(MBOX_BUSY_BIT) | cmd_id;
    55		writel(data, (void __iomem *) ((proc_priv->mmio_base + MBOX_OFFSET_INTERFACE)));
    56	
    57		/* Poll for rb bit == 0 */
    58		retries = MBOX_RETRY_COUNT;
    59		do {
    60			data = readl((void __iomem *) (proc_priv->mmio_base + MBOX_OFFSET_INTERFACE));
    61			if (data & BIT_ULL(MBOX_BUSY_BIT)) {
    62				ret = -EBUSY;
    63				continue;
    64			}
    65	
    66			if (data) {
    67				ret = -ENXIO;
    68				goto unlock_mbox;
    69			}
    70	
    71			ret = 0;
    72	
    73			if (!cmd_resp)
    74				break;
    75	
    76			if (cmd_id == MBOX_CMD_WORKLOAD_TYPE_READ)
    77				*cmd_resp = readl((void __iomem *) (proc_priv->mmio_base + MBOX_OFFSET_DATA));
    78			else
  > 79				*cmd_resp = readq((void __iomem *) (proc_priv->mmio_base + MBOX_OFFSET_DATA));
    80	
    81			break;
    82		} while (--retries);
    83	
    84	unlock_mbox:
    85		mutex_unlock(&mbox_lock);
    86		return ret;
    87	}
    88	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (34185 bytes)