linux-kernel - Re: [PATCH V2 0/4] mm/damon: Do some small changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 11 Nov 2021 23:44:18 +0800
From:   Xin Hao <xhao@...ux.alibaba.com>
To:     SeongJae Park <sj@...nel.org>
Cc:     sjpark@...zon.de, akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 0/4] mm/damon: Do some small changes

Hi, Park:

On 2021/11/11 下午5:24, SeongJae Park wrote:
> Hello Xin,
>
> On Thu, 11 Nov 2021 14:07:00 +0800 Xin Hao <xhao@...ux.alibaba.com> wrote:
>
>> These four patches are mainly to do some small changes.
>>
>> V1 -> V2
>> 	Add reviewed by SeongJae Park
>> 	Add two new patches
>> V1:
>> https://lore.kernel.org/linux-mm/cover.1636546262.git.xhao@linux.alibaba.com/
>>
>>
>> Xin Hao (4):
>>    mm/damon: Unified access_check function naming rules
>>    mm/damon: Add 'age' of region tracepoint support
>>    mm/damon/core: Using function abs() instead of diff_of()
>>    mm/damon: Remove some no need func definitions in damon.h file
> Overall, all patches looks good to me, though I asked[1] a trivial change in
> the commit message of the second patch.
Ok,  I will add a detail message to explain it in commit in my next 
patch, thanks.
>
> Also, I found one interesting thing.  It seems you are wrapping body of the
> commit messages at <75 columns[2]?  That's obviously neither a problem, nor
> even trivial nit.  But... I'd prefer the messages look more consistent with
> others.
Thank you very much for your careful correction,  I will fix it in my 
next patch too.
>
> [1] https://lore.kernel.org/linux-mm/20211111082034.13323-1-sj@kernel.org/
> [2] https://docs.kernel.org/process/submitting-patches.html?highlight=75#the-canonical-patch-format
>
>
> Thanks,
> SJ
>
>>   include/linux/damon.h        | 25 ++-----------------------
>>   include/trace/events/damon.h |  7 +++++--
>>   mm/damon/core.c              |  6 ++----
>>   mm/damon/vaddr.c             |  8 ++++----
>>   4 files changed, 13 insertions(+), 33 deletions(-)
>>
>> --
>> 2.31.0

-- 
Best Regards!
Xin Hao