linux-kernel - Re: [PATCH] ARM: s3c: include header for prototype of s3c2410_modify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 Nov 2021 17:41:49 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" 
        <linux-samsung-soc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] ARM: s3c: include header for prototype of s3c2410_modify_misccr

On Thu, Nov 11, 2021 at 10:56 AM Krzysztof Kozlowski
<krzysztof.kozlowski@...onical.com> wrote:
>
> On 11/11/2021 10:46, Arnd Bergmann wrote:
> > On Thu, Nov 11, 2021 at 10:11 AM Krzysztof Kozlowski
> > <krzysztof.kozlowski@...onical.com> wrote:
> >>
> >> Include the header with prototype of s3c2410_modify_misccr to fix W=1
> >> warning:
> >>
> >>   arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning:
> >>     no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes]
> >>
> >> Reported-by: kernel test robot <lkp@...el.com>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> >
> > Thank you for fixing it,
> >
> > Acked-by: Arnd Bergmann <arnd@...db.de>
> >
> > If you like, I can put it into the fixes branch of the soc tree directly,
> > otherwise I expect you'll send it in a pull request later.
>
> It's not a serious bug and was there since long time, so maybe let's
> send it via regular pull request.

Ok, sounds good. I was worried for a bit that this would break builds
with CONFIG_WERROR, but of course that is already broken in
many ways with W=1.

        Arnd