linux-kernel - Re: [PATCH] gpio: xlp: Remove Netlogic XLP variants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 Nov 2021 21:28:14 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Bartosz Golaszewski <brgl@...ev.pl>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        "open list:MIPS" <linux-mips@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH] gpio: xlp: Remove Netlogic XLP variants

On Thu, Nov 11, 2021 at 9:13 PM Rob Herring <robh@...nel.org> wrote:
> On Thu, Nov 11, 2021 at 4:43 AM Linus Walleij <linus.walleij@...aro.org> wrote:

> > > @@ -373,7 +263,7 @@ static int xlp_gpio_probe(struct platform_device *pdev)
> > >         gc->label = dev_name(&pdev->dev);
> > >         gc->base = 0;
> >
> > Can we also set this to -1 and use dynamic GPIO base allocation?
> > (Can be a separate patch.)
>
> No clue. What's normal for GPIO ACPI systems?

Dynamic allocation (-1) c.f.
drivers/pinctrl/intel/pinctrl-intel.c

> Does that mean more than
> 1 instance is broken currently?

Yes.

Yours,
Linus Walleij