linux-kernel - Re: [PATCH v2] gpio: Return EPROBE_DEFER if gc->to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 Nov 2021 21:40:27 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     kernel test robot <lkp@...el.com>
Cc:     Shreeya Patel <shreeya.patel@...labora.com>,
        bgolaszewski@...libre.com, wsa@...nel.org, krisman@...labora.com,
        sebastian.reichel@...labora.com, kbuild-all@...ts.01.org,
        kernel@...labora.com, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org
Subject: Re: [PATCH v2] gpio: Return EPROBE_DEFER if gc->to_irq is NULL

On Wed, Nov 10, 2021 at 10:16 AM kernel test robot <lkp@...el.com> wrote:

>    drivers/gpio/gpiolib.c: In function 'gpiod_to_irq':
> >> drivers/gpio/gpiolib.c:3068:15: error: 'struct gpio_chip' has no member named 'irq'
>     3068 |         if (gc->irq.chip) {
>          |               ^~

Right you need an #ifdef CONFIG_GPIOLIB_IRQCHIP in this
case I would try:

if (IS_ENABLED(CONFIG_GPIOLIB_IRQCHIP) && gc->irq.chip)

hoping the compiler is smart enough to deal with that
(but I'm not sure it is)

Yours,
Linus Walleij