linux-kernel - Re: [PATCH 1/4] x86/mm: make init_trampoline_kaslr() _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 Nov 2021 20:46:32 +0000
From:   "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>
To:     "rppt@...nel.org" <rppt@...nel.org>,
        "x86@...nel.org" <x86@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "hpa@...or.com" <hpa@...or.com>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "rppt@...ux.ibm.com" <rppt@...ux.ibm.com>,
        "Lutomirski, Andy" <luto@...nel.org>, "bp@...en8.de" <bp@...en8.de>
Subject: Re: [PATCH 1/4] x86/mm: make init_trampoline_kaslr() __init

On Thu, 2021-11-11 at 13:02 +0200, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@...ux.ibm.com>
> 
> init_trampoline_kaslr() is __meminit although it is only called by
> __init
> function init_trampoline().
> 
> Make init_trampoline_kaslr() __init.
> 
> Signed-off-by: Mike Rapoport <rppt@...ux.ibm.com>

Reviewed-by: Rick Edgecombe <rick.p.edgecombe@...el.com>

> ---
>  arch/x86/mm/kaslr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/mm/kaslr.c b/arch/x86/mm/kaslr.c
> index 557f0fe25dff..d40bb4feeda3 100644
> --- a/arch/x86/mm/kaslr.c
> +++ b/arch/x86/mm/kaslr.c
> @@ -138,7 +138,7 @@ void __init kernel_randomize_memory(void)
>  	}
>  }
>  
> -void __meminit init_trampoline_kaslr(void)
> +void __init init_trampoline_kaslr(void)
>  {
>  	pud_t *pud_page_tramp, *pud, *pud_tramp;
>  	p4d_t *p4d_page_tramp, *p4d, *p4d_tramp;