linux-kernel - Re: [PATCH v2] net/ipa: ipa_resource: Fix wrong for loop range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <337396cb-0959-561d-8abd-7cf6e48d6fae@ieee.org>
Date:   Thu, 11 Nov 2021 15:25:23 -0600
From:   Alex Elder <elder@...e.org>
To:     Konrad Dybcio <konrad.dybcio@...ainline.org>,
        ~postmarketos/upstreaming@...ts.sr.ht
Cc:     martin.botka@...ainline.org,
        angelogioacchino.delregno@...ainline.org,
        marijn.suijten@...ainline.org, jamipkettunen@...ainline.org,
        Alex Elder <elder@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net/ipa: ipa_resource: Fix wrong for loop range

On 11/11/21 12:37 PM, Konrad Dybcio wrote:
> The source group count was mistakenly assigned to both dst and src loops.
> Fix it to make IPA probe and work again.

Looks good.  Oops.

Reviewed-by: Alex Elder <elder@...aro.org>

> 
> Fixes: 4fd704b3608a ("net: ipa: record number of groups in data")
> Acked-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...ainline.org>
> Reviewed-by: Marijn Suijten <marijn.suijten@...ainline.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@...ainline.org>
> ---
> Changes since v1:
> - Add a "Fixes:" tag, R-b, A-b and fix up the commit message
>   drivers/net/ipa/ipa_resource.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ipa/ipa_resource.c b/drivers/net/ipa/ipa_resource.c
> index e3da95d69409..06cec7199382 100644
> --- a/drivers/net/ipa/ipa_resource.c
> +++ b/drivers/net/ipa/ipa_resource.c
> @@ -52,7 +52,7 @@ static bool ipa_resource_limits_valid(struct ipa *ipa,
>   				return false;
>   	}
>   
> -	group_count = data->rsrc_group_src_count;
> +	group_count = data->rsrc_group_dst_count;
>   	if (!group_count || group_count > IPA_RESOURCE_GROUP_MAX)
>   		return false;
>   
>